Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bugfix for About Settings test #7413

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

KMaragh
Copy link
Contributor

@KMaragh KMaragh commented Dec 30, 2019

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@KMaragh KMaragh added 🐞 bug Crashes, Something isn't working, .. pr:do-not-land labels Dec 30, 2019
@KMaragh KMaragh self-assigned this Dec 30, 2019
@codecov-io
Copy link

codecov-io commented Dec 30, 2019

Codecov Report

Merging #7413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7413   +/-   ##
=========================================
  Coverage     19.62%   19.62%           
  Complexity      469      469           
=========================================
  Files           300      300           
  Lines         11531    11531           
  Branches       1561     1561           
=========================================
  Hits           2263     2263           
  Misses         9093     9093           
  Partials        175      175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399df17...e7e6cde. Read the comment docs.

@KMaragh KMaragh changed the title Testing: Kicking off firebase Bugfix for About Settings Dec 30, 2019
@KMaragh KMaragh changed the title Bugfix for About Settings Bugfix for About Settings test Dec 30, 2019
@KMaragh KMaragh added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Dec 30, 2019
@KMaragh KMaragh removed pr:do-not-land pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Jan 3, 2020
@KMaragh KMaragh force-pushed the bugfix-7388 branch 2 times, most recently from bfd2b95 to a98ae75 Compare January 8, 2020 19:08
@rpappalax rpappalax added the eng:automation Build automation, Continuous integration, .. label Jan 8, 2020
Copy link
Contributor

@rpappalax rpappalax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a few comments, moving some stuff to helper function then all green on Firebase then good to go! 👍

@KMaragh KMaragh force-pushed the bugfix-7388 branch 3 times, most recently from 17e0d6e to 1341e48 Compare January 13, 2020 19:46
…n for external links in About Preview Screen
@rpappalax rpappalax merged commit fb2a68f into mozilla-mobile:master Jan 13, 2020
@liuche liuche mentioned this pull request Jan 22, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants