This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7413 +/- ##
=========================================
Coverage 19.62% 19.62%
Complexity 469 469
=========================================
Files 300 300
Lines 11531 11531
Branches 1561 1561
=========================================
Hits 2263 2263
Misses 9093 9093
Partials 175 175 Continue to review full report at Codecov.
|
KMaragh
added
the
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
label
Dec 30, 2019
KMaragh
removed
pr:do-not-land
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
labels
Jan 3, 2020
KMaragh
force-pushed
the
bugfix-7388
branch
2 times, most recently
from
January 8, 2020 19:08
bfd2b95
to
a98ae75
Compare
rpappalax
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a few comments, moving some stuff to helper function then all green on Firebase then good to go! 👍
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAboutRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAboutRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAboutRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAboutRobot.kt
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAboutRobot.kt
Show resolved
Hide resolved
KMaragh
force-pushed
the
bugfix-7388
branch
3 times, most recently
from
January 13, 2020 19:46
17e0d6e
to
1341e48
Compare
…n for external links in About Preview Screen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🐞 bug
Crashes, Something isn't working, ..
eng:automation
Build automation, Continuous integration, ..
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: