Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6832: fix unattached context crash in HomeFragment #7509

Merged
merged 2 commits into from
Jan 8, 2020
Merged

For #6832: fix unattached context crash in HomeFragment #7509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b073fac
For #6832: fix unattached context crash in HomeFragment
severinrudie Jan 6, 2020
4fba3cd
For 6832: update implementation/comment to align w existing AC code
severinrudie Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,14 @@ class HomeFragment : Fragment() {
setupHomeMenu()

viewLifecycleOwner.lifecycleScope.launch(IO) {
// This is necessary due to a bug in viewLifecycleOwner. See:
// https://github.com/mozilla-mobile/android-components/blob/master/components/lib/state/src/main/java/mozilla/components/lib/state/ext/Fragment.kt#L32-L56
// TODO remove when viewLifecycleOwner is fixed
val context = context ?: return@launch
severinrudie marked this conversation as resolved.
Show resolved Hide resolved

val iconSize = resources.getDimensionPixelSize(R.dimen.preference_icon_drawable_size)

val searchEngine = requireComponents.search.provider.getDefaultEngine(requireContext())
val searchEngine = requireComponents.search.provider.getDefaultEngine(context)
val searchIcon = BitmapDrawable(resources, searchEngine.icon)
searchIcon.setBounds(0, 0, iconSize, iconSize)

Expand Down