Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Make nimbledroid not depend on a real token on staging releases #7570

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

JohanLorenzo
Copy link
Contributor

Hey @kglazko!

I remember we talked about making the nimbledroid task easier to use when doing staging nighlies/releases. I found a way that still kicks off the task, but doesn't interact with the Nimbledroid service. How does it look to you?

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

by-level:
'3': []
default:
- [echo, '--', '>', .nimbledroid_token]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is inspired by this logic in the build tasks:

task["run"]["pre-gradlew"] = [[
"echo", '"{}"'.format(fake_value), ">", target_file
] for fake_value, target_file in (
("--", ".adjust_token"),
("", ".digital_asset_links_token"),
("-:-", ".leanplum_token"),
("https://fake@sentry.prod.mozaws.net/368", ".sentry_token"),
)]

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #7570 into master will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7570      +/-   ##
============================================
+ Coverage     18.66%   19.47%   +0.81%     
+ Complexity      459      457       -2     
============================================
  Files           319      300      -19     
  Lines         12725    11500    -1225     
  Branches       1677     1554     -123     
============================================
- Hits           2375     2240     -135     
+ Misses        10149     9090    -1059     
+ Partials        201      170      -31
Impacted Files Coverage Δ Complexity Δ
.../java/org/mozilla/fenix/ext/ConnectivityManager.kt 14.28% <0%> (-28.58%) 0% <0%> (ø)
...rg/mozilla/fenix/components/toolbar/ToolbarMenu.kt 77.27% <0%> (-18.38%) 0% <0%> (ø)
...java/org/mozilla/fenix/components/FenixSnackbar.kt 0% <0%> (-15.28%) 0% <0%> (ø)
...ttings/advanced/DefaultLocaleSettingsController.kt 80% <0%> (-12.86%) 4% <0%> (-2%)
...fenix/settings/deletebrowsingdata/DeleteAndQuit.kt 57.14% <0%> (-9.53%) 0% <0%> (ø)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 4.95% <0%> (-9.34%) 2% <0%> (-1%)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 70.79% <0%> (-8.5%) 20% <0%> (-8%)
...deletebrowsingdata/DeleteBrowsingDataController.kt 88% <0%> (-7.46%) 0% <0%> (ø)
...in/java/org/mozilla/fenix/components/Components.kt 29.41% <0%> (-6.15%) 1% <0%> (ø)
...g/mozilla/fenix/settings/advanced/LocaleAdapter.kt 0% <0%> (-4.62%) 0% <0%> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3486f30...f4a63c5. Read the comment docs.

Copy link
Contributor

@kglazko kglazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm not sure if you still want to make these changes given our talk today. If you want to for the short-term, feel free!

@JohanLorenzo
Copy link
Contributor Author

JohanLorenzo commented Feb 20, 2020

Chatted on Slack with both @kglazko and @mcomella. We're good to land these changes!

@JohanLorenzo JohanLorenzo merged commit cb7791d into mozilla-mobile:master Feb 20, 2020
@JohanLorenzo JohanLorenzo deleted the nimbledroid-stage branch February 20, 2020 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants