-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make nimbledroid not depend on a real token on staging releases #7570
Make nimbledroid not depend on a real token on staging releases #7570
Conversation
by-level: | ||
'3': [] | ||
default: | ||
- [echo, '--', '>', .nimbledroid_token] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is inspired by this logic in the build tasks:
fenix/taskcluster/fenix_taskgraph/transforms/build.py
Lines 52 to 59 in b23ee38
task["run"]["pre-gradlew"] = [[ | |
"echo", '"{}"'.format(fake_value), ">", target_file | |
] for fake_value, target_file in ( | |
("--", ".adjust_token"), | |
("", ".digital_asset_links_token"), | |
("-:-", ".leanplum_token"), | |
("https://fake@sentry.prod.mozaws.net/368", ".sentry_token"), | |
)] |
Codecov Report
@@ Coverage Diff @@
## master #7570 +/- ##
============================================
+ Coverage 18.66% 19.47% +0.81%
+ Complexity 459 457 -2
============================================
Files 319 300 -19
Lines 12725 11500 -1225
Branches 1677 1554 -123
============================================
- Hits 2375 2240 -135
+ Misses 10149 9090 -1059
+ Partials 201 170 -31
Continue to review full report at Codecov.
|
48e8a39
to
f4f7353
Compare
f4f7353
to
f4a63c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'm not sure if you still want to make these changes given our talk today. If you want to for the short-term, feel free!
Hey @kglazko!
I remember we talked about making the nimbledroid task easier to use when doing staging nighlies/releases. I found a way that still kicks off the task, but doesn't interact with the Nimbledroid service. How does it look to you?
Pull Request checklist
After merge
To download an APK when reviewing a PR: