Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

7506 show highlight on home 3-dot button #7665

Merged

Conversation

severinrudie
Copy link
Contributor

@severinrudie severinrudie commented Jan 14, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Screenshots

Screen Shot 2020-01-16 at 10 47 32 AM

Screen Shot 2020-01-16 at 10 47 27 AM

@severinrudie severinrudie force-pushed the 7506-highlight-home-three-dot branch 3 times, most recently from 10e66f6 to dfefd6c Compare January 14, 2020 01:44
@severinrudie severinrudie changed the title temp (temp) show highlight on home three-dot Jan 14, 2020
@severinrudie severinrudie changed the title (temp) show highlight on home three-dot 7506 show highlight on home 3-dot button Jan 16, 2020
severinrudie added a commit to severinrudie/android-components that referenced this pull request Jan 16, 2020
@severinrudie severinrudie added this to In progress in Feature Polish via automation Jan 16, 2020
severinrudie added a commit to severinrudie/android-components that referenced this pull request Jan 16, 2020
@severinrudie severinrudie marked this pull request as ready for review January 16, 2020 18:53
Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval. We need to update AC first before merging this.

@severinrudie severinrudie force-pushed the 7506-highlight-home-three-dot branch 2 times, most recently from 86604c7 to 570903a Compare January 17, 2020 03:22
@severinrudie
Copy link
Contributor Author

Tentative approval. We need to update AC first before merging this.

Specifically, we're waiting on mozilla-mobile/android-components#5620

@severinrudie severinrudie self-assigned this Jan 17, 2020
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #7665 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7665      +/-   ##
============================================
+ Coverage     19.14%   19.15%   +<.01%     
  Complexity      451      451              
============================================
  Files           301      301              
  Lines         11666    11660       -6     
  Branches       1583     1581       -2     
============================================
  Hits           2234     2234              
+ Misses         9247     9241       -6     
  Partials        185      185
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355cb35...891d435. Read the comment docs.

@severinrudie severinrudie merged commit 2dc5b39 into mozilla-mobile:master Jan 21, 2020
Feature Polish automation moved this from In progress to Done Jan 21, 2020
@liuche liuche mentioned this pull request Jan 22, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants