This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
7506 show highlight on home 3-dot button #7665
Merged
severinrudie
merged 1 commit into
mozilla-mobile:master
from
severinrudie:7506-highlight-home-three-dot
Jan 21, 2020
Merged
7506 show highlight on home 3-dot button #7665
severinrudie
merged 1 commit into
mozilla-mobile:master
from
severinrudie:7506-highlight-home-three-dot
Jan 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinrudie
force-pushed
the
7506-highlight-home-three-dot
branch
3 times, most recently
from
January 14, 2020 01:44
10e66f6
to
dfefd6c
Compare
severinrudie
changed the title
(temp) show highlight on home three-dot
7506 show highlight on home 3-dot button
Jan 16, 2020
severinrudie
force-pushed
the
7506-highlight-home-three-dot
branch
from
January 16, 2020 18:03
dfefd6c
to
ae55c48
Compare
severinrudie
added a commit
to severinrudie/android-components
that referenced
this pull request
Jan 16, 2020
This is in support of mozilla-mobile/fenix#7665
severinrudie
added a commit
to severinrudie/android-components
that referenced
this pull request
Jan 16, 2020
This is in support of mozilla-mobile/fenix#7665
Closed
6 tasks
NotWoods
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval. We need to update AC first before merging this.
severinrudie
force-pushed
the
7506-highlight-home-three-dot
branch
2 times, most recently
from
January 17, 2020 03:22
86604c7
to
570903a
Compare
Specifically, we're waiting on mozilla-mobile/android-components#5620 |
severinrudie
force-pushed
the
7506-highlight-home-three-dot
branch
from
January 21, 2020 19:11
570903a
to
891d435
Compare
Codecov Report
@@ Coverage Diff @@
## master #7665 +/- ##
============================================
+ Coverage 19.14% 19.15% +<.01%
Complexity 451 451
============================================
Files 301 301
Lines 11666 11660 -6
Branches 1583 1581 -2
============================================
Hits 2234 2234
+ Misses 9247 9241 -6
Partials 185 185
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR:
Screenshots