This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #8176 - Adds new string for add to top sites. #8209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boek
reviewed
Feb 7, 2020
| @@ -352,7 +352,7 @@ sealed class Event { | |||
| enum class Item { | |||
| SETTINGS, LIBRARY, HELP, DESKTOP_VIEW_ON, DESKTOP_VIEW_OFF, FIND_IN_PAGE, NEW_TAB, | |||
| NEW_PRIVATE_TAB, SHARE, REPORT_SITE_ISSUE, BACK, FORWARD, RELOAD, STOP, OPEN_IN_FENIX, | |||
| SAVE_TO_COLLECTION, ADD_TO_FIREFOX_HOME, ADD_TO_HOMESCREEN, QUIT, READER_MODE_ON, | |||
There was a problem hiding this comment.
Should we update this as well? https://github.com/mozilla-mobile/fenix/blob/master/app/metrics.yaml#L81
ekager
force-pushed
the
strings
branch
2 times, most recently
from
57463d8
to
6dcff4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #8209 +/- ##
============================================
+ Coverage 18.67% 18.67% +<.01%
Complexity 452 452
============================================
Files 316 316
Lines 12331 12329 -2
Branches 1619 1619
============================================
Hits 2303 2303
+ Misses 9829 9827 -2
Partials 199 199
Continue to review full report at Codecov.
|
gabrielluong
approved these changes
Feb 7, 2020
| @@ -221,15 +221,12 @@ class DefaultToolbarMenu( | |||
| onItemTapped.invoke(ToolbarMenu.Item.RequestDesktop(checked)) | |||
| } | |||
|
|
|||
| private val addToFirefoxHome = BrowserMenuImageText( | |||
| label = context.getString( | |||
| R.string.browser_menu_add_to_firefox_home, | |||
There was a problem hiding this comment.
I think we can remove "browser_menu_add_to_firefox_home" string as well.
gabrielluong
changed the title
gabrielluong
changed the title
ekager
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: