-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UITests: New tests for save Login prompt #8381
UITests: New tests for save Login prompt #8381
Conversation
20fb73d
to
5c32f2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #8381 +/- ##
============================================
- Coverage 18.59% 18.57% -0.03%
Complexity 459 459
============================================
Files 319 318 -1
Lines 12728 12616 -112
Branches 1680 1662 -18
============================================
- Hits 2367 2343 -24
+ Misses 10161 10074 -87
+ Partials 200 199 -1
Continue to review full report at Codecov.
|
5c32f2e
to
ec71291
Compare
}.openThreeDotMenu { | ||
}.openSettings { | ||
// Necessary to scroll a little bit for all screen sizes | ||
TestHelper.scrollToElementByText("Logins and passwords") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
|
||
navigationToolbar { | ||
}.enterURLAndEnterToBrowser(saveLoginTest.url) { | ||
mDevice.waitNotNull(Until.findObjects(By.text("test@example.com")), TestAssetHelper.waitingTime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving all of these methods into the browser robot will make it easier to read what is going on in this test class.
}.openHomeScreen { | ||
}.openThreeDotMenu { | ||
}.openSettings { | ||
TestHelper.scrollToElementByText("Logins and passwords") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this into the openLoginsAndPasswordSubmenu function. This way anytime you expect to open the menu, the function will scroll there for you.
5f03de0
to
8ffda8b
Compare
* UITests: New tests for save Login prompt * fixing firebase timing issues when webpage loads * adding tests for don't save and check the prompt options * fix detekt issue * fix reviewer comments
This PR adds tests for the Save Login prompt feature
Pull Request checklist
After merge
To download an APK when reviewing a PR: