Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #8544: Activity should be reused when opening intents from other apps #8547

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #8547 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #8547      +/-   ##
===========================================
+ Coverage     18.67%   18.7%   +0.02%     
  Complexity      464     464              
===========================================
  Files           319     319              
  Lines         12754   12756       +2     
  Branches       1680    1680              
===========================================
+ Hits           2382    2386       +4     
+ Misses        10170   10168       -2     
  Partials        202     202
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...mponents/searchengine/FenixSearchEngineProvider.kt 56.52% <0%> (+4.34%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae294c3...0f8322b. Read the comment docs.

@rocketsroger rocketsroger changed the title Closes #8544: Activity should be reused when opening intents from other apps Closes #8544: Activity should be reused when opening intents from other apps. Feb 19, 2020
@boek boek changed the title Closes #8544: Activity should be reused when opening intents from other apps. 🎲 Closes #8544: Activity should be reused when opening intents from other apps. Feb 20, 2020
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. But a test failed. Let's rerun.

@pocmo
Copy link
Contributor

pocmo commented Feb 20, 2020

Or not, looks like you already rerun.

@pocmo pocmo changed the title 🎲 Closes #8544: Activity should be reused when opening intents from other apps. Closes #8544: Activity should be reused when opening intents from other apps. Feb 20, 2020
@rocketsroger
Copy link
Contributor Author

Or not, looks like you already rerun.

Yes, but it was a "connection reset" issue last run. Let me take a look.

@rocketsroger
Copy link
Contributor Author

Or not, looks like you already rerun.

Yes, but it was a "connection reset" issue last run. Let me take a look.

Failure doesn't look like its related to my change.

@rocketsroger rocketsroger changed the title Closes #8544: Activity should be reused when opening intents from other apps. Closes #8544: Activity should be reused when opening intents from other apps Feb 20, 2020
@rocketsroger rocketsroger changed the title Closes #8544: Activity should be reused when opening intents from other apps Closes #8544: Activity should be reused when opening intents from other apps. Feb 20, 2020
@rocketsroger rocketsroger changed the title Closes #8544: Activity should be reused when opening intents from other apps. Closes #8544: Activity should be reused when opening intents from other apps Feb 21, 2020
@rocketsroger rocketsroger changed the title Closes #8544: Activity should be reused when opening intents from other apps Closes #8544: Activity should be reused when opening intents from other apps. Feb 21, 2020
@rocketsroger rocketsroger changed the title Closes #8544: Activity should be reused when opening intents from other apps. Closes #8544: Activity should be reused when opening intents from other apps Feb 21, 2020
@rocketsroger rocketsroger merged commit 0630e24 into mozilla-mobile:master Feb 21, 2020
@rocketsroger rocketsroger deleted the FB_8544 branch January 5, 2021 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants