Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1616641 - let fennec-nightly tasks ride along vanilla fenix nightlies #8579

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

MihaiTabara
Copy link
Contributor

@MihaiTabara MihaiTabara commented Feb 20, 2020

We no longer need standalone fennec-nightly graphs. Hence we remove their graph definitions and let those tasks ride along the vanilla fenix nightlies.

Moreover, we want the fennec-nightly push-apk job to push to beta track directly, rather than alpha track so that Fenix folks have one less thing to take care of, now that we're 100% migrated on Fenix nightly. That change is tracked in mozilla-releng/scriptworker-scripts#148

@MihaiTabara
Copy link
Contributor Author

Tested via taskgraph locally and the three additional tasks show up successfully in the fenix graph: build, signing and pushapk.

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #8579 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #8579      +/-   ##
===========================================
+ Coverage     18.66%   18.7%   +0.03%     
  Complexity      464     464              
===========================================
  Files           319     319              
  Lines         12754   12754              
  Branches       1680    1680              
===========================================
+ Hits           2381    2386       +5     
+ Misses        10172   10166       -6     
- Partials        201     202       +1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/components/Search.kt 91.66% <0%> (ø) 2% <0%> (ø) ⬇️
...mponents/searchengine/FenixSearchEngineProvider.kt 56.52% <0%> (+5.43%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7791d...5e0516d. Read the comment docs.

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to remove fennec-nightly and make the fennec/nightly branch obsolete. I saw on Slack @pocmo agrees, so 👍

@MihaiTabara MihaiTabara merged commit ae294c3 into mozilla-mobile:master Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants