Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update IntentProcessor implementation to comply with new interface #8971

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Mar 4, 2020

We changed the Fenix implementation in #8823. And removed matches() from the interface in AC in mozilla-mobile/android-components#6097. Now we can remove the override keyword from the IntentProcessor implementations living in Fenix.

@ekager ekager changed the title Update IntentProcessor implementation to comply with new interface. Update IntentProcessor implementation to comply with new interface Mar 4, 2020
@pocmo
Copy link
Contributor Author

pocmo commented Mar 4, 2020

Oh, missed the tests. Updating!

@codecov-io
Copy link

Codecov Report

Merging #8971 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8971      +/-   ##
============================================
+ Coverage      18.9%   18.94%   +0.03%     
- Complexity      500      502       +2     
============================================
  Files           330      330              
  Lines         13043    13043              
  Branches       1725     1725              
============================================
+ Hits           2466     2471       +5     
+ Misses        10367    10361       -6     
- Partials        210      211       +1
Impacted Files Coverage Δ Complexity Δ
...e/intent/FennecBookmarkShortcutsIntentProcessor.kt 91.66% <ø> (+8.33%) 5 <0> (+2) ⬆️
...la/fenix/shortcut/NewTabShortcutIntentProcessor.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...la/fenix/customtabs/FennecWebAppIntentProcessor.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...nix/components/toolbar/BrowserToolbarController.kt 64.53% <0%> (+2.32%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8296b3e...eec2797. Read the comment docs.

@ekager ekager merged commit 7b170c4 into mozilla-mobile:master Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants