Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #7158: Improves home to search animation #9008

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Mar 5, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #9008 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #9008      +/-   ##
===========================================
+ Coverage     18.88%   18.9%   +0.01%     
  Complexity      502     502              
===========================================
  Files           330     330              
  Lines         13061   13047      -14     
  Branches       1727    1727              
===========================================
- Hits           2467    2466       -1     
+ Misses        10384   10371      -13     
  Partials        210     210
Impacted Files Coverage Δ Complexity Δ
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ix/home/sessioncontrol/SessionControlController.kt 66.08% <0%> (-0.87%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84afb5d...b5086b1. Read the comment docs.

Copy link
Contributor

@severinrudie severinrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I like the animation too, happy to get this in.

@sblatz sblatz merged commit 28f58eb into mozilla-mobile:master Mar 5, 2020
@liuche liuche mentioned this pull request Mar 12, 2020
32 tasks
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants