Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1619795: Cleanup. #9015

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

tomprince
Copy link
Contributor

There were a couple of errors in the original pull request for this bug:

  • The raptor tasks had duplicated dependencies.
  • The filename of the minidump_stackwalk artifact was incorrect.

There were a couple of errors in the original pull request for this bug:
- The raptor tasks had duplicated dependencies.
- The filename of the minidump_stackwalk artifact was incorrect.
@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #9015 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9015      +/-   ##
============================================
+ Coverage      18.9%   18.95%   +0.04%     
  Complexity      502      502              
============================================
  Files           330      330              
  Lines         13049    13049              
  Branches       1727     1727              
============================================
+ Hits           2467     2473       +6     
+ Misses        10372    10366       -6     
  Partials        210      210
Impacted Files Coverage Δ Complexity Δ
...mponents/searchengine/FenixSearchEngineProvider.kt 65.95% <0%> (+2.12%) 15% <0%> (ø) ⬇️
...nix/components/toolbar/BrowserToolbarController.kt 64.53% <0%> (+2.32%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0436c8d...d2335e4. Read the comment docs.

@tomprince tomprince force-pushed the fix-raptor branch 2 times, most recently from a78fc06 to d2335e4 Compare March 6, 2020 08:52
@tomprince tomprince marked this pull request as ready for review March 6, 2020 08:52
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohanLorenzo JohanLorenzo merged commit 90dafcf into mozilla-mobile:master Mar 6, 2020
@liuche liuche mentioned this pull request Mar 12, 2020
32 tasks
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
There were a couple of errors in the original pull request for this bug:
- The raptor tasks had duplicated dependencies.
- The filename of the minidump_stackwalk artifact was incorrect.
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants