Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #3086: Adds settings animations #9187

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Mar 16, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #9187 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9187      +/-   ##
============================================
- Coverage     19.51%   19.50%   -0.02%     
  Complexity      511      511              
============================================
  Files           329      329              
  Lines         13147    13155       +8     
  Branches       1746     1747       +1     
============================================
  Hits           2566     2566              
- Misses        10356    10364       +8     
  Partials        225      225              
Impacted Files Coverage Δ Complexity Δ
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a457755...fea4df9. Read the comment docs.

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small nit :)

@@ -114,6 +117,8 @@ class SettingsFragment : PreferenceFragmentCompat() {
showToolbar(getString(R.string.settings_title))

update()

view!!.findViewById<RecyclerView>(R.id.recycler_view)?.hideInitialScrollBar(lifecycleScope)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the kotlin view getter here? view?.recycler_view?.hideInitialScrollbar(lifecycleScope)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no. I tried this, and it doesn't work. My guess is that it's because we don't have direct access to the recycler view. This is actually one Android is generating based on the build in PreferenceFragment.

@sblatz sblatz merged commit b4e1360 into mozilla-mobile:master Mar 17, 2020
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants