-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
2d7b7a7
to
5eac976
Compare
5eac976
to
5703e95
Compare
Codecov Report
@@ Coverage Diff @@
## master #9187 +/- ##
============================================
- Coverage 19.51% 19.50% -0.02%
Complexity 511 511
============================================
Files 329 329
Lines 13147 13155 +8
Branches 1746 1747 +1
============================================
Hits 2566 2566
- Misses 10356 10364 +8
Partials 225 225
Continue to review full report at Codecov.
|
5703e95
to
1cf4a55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a small nit :)
@@ -114,6 +117,8 @@ class SettingsFragment : PreferenceFragmentCompat() { | |||
showToolbar(getString(R.string.settings_title)) | |||
|
|||
update() | |||
|
|||
view!!.findViewById<RecyclerView>(R.id.recycler_view)?.hideInitialScrollBar(lifecycleScope) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the kotlin view getter here? view?.recycler_view?.hideInitialScrollbar(lifecycleScope)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, no. I tried this, and it doesn't work. My guess is that it's because we don't have direct access to the recycler view. This is actually one Android is generating based on the build in PreferenceFragment.
1cf4a55
to
fea4df9
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR: