Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1621252 - Move Fenix Raptor tests to tier 1 #9217

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Mar 18, 2020

Pushing this from #9197 to run CI - though I don't think this will run the Raptor CI, will it @JohanLorenzo ? I guess we'll see!

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@bebef1987
Copy link
Contributor

I think we are OK here
Decision Task Successful in 1m — FirefoxCI (pull_request)

Last time Decision Task was failing with:

Exception: raptor-tp6m-13-cold-performance-test-armeabi-v7a (tier 1) cannot depend on signing-performance-test (tier 2)

@bebef1987
Copy link
Contributor

it would be nice to have the power to trigger a actual raptor test

@JohanLorenzo
Copy link
Contributor

Hey @bebef1987!

I have some great news! @tomprince recently enabled a feature. I tested it last week and it worked great. I'm going to document this, but in the meantime, you can just create a file called try_task_config.json in the main folder. Commit/push it and you will be able to trigger an actual raptor test.

Here's what the file should contain:

{
    "parameters": {
        "optimize_target_tasks": true,
        "target_tasks_method": "raptor"
    },
    "version": 2
}

@bebef1987
Copy link
Contributor

@JohanLorenzo I don't have the power to trigger these builds that's why @liuche had to make a copy of my pull request...

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bebef1987 Oh my apologies! I hadn't realized you didn't. I just pushed the change I mentioned. Here's what will happen once your PR is merged. I see the decision task is green, so this PR is in good shape.

By the way, I'm sorry I didn't catch the bug in the original PR. I had forgotten taskgraph was super strict with tiers.

I'm going to push a backout of my commit once tests are green :)

@codecov-io
Copy link

Codecov Report

Merging #9217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9217   +/-   ##
=========================================
  Coverage     19.49%   19.49%           
  Complexity      511      511           
=========================================
  Files           329      329           
  Lines         13156    13156           
  Branches       1748     1748           
=========================================
  Hits           2565     2565           
  Misses        10365    10365           
  Partials        226      226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd4cdd...24f77f5. Read the comment docs.

@JohanLorenzo JohanLorenzo merged commit ae67452 into mozilla-mobile:master Mar 18, 2020
@liuche liuche deleted the bebef198-second-attempt branch March 18, 2020 19:38
severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020
Co-authored-by: Florin Strugariu <bebe@mozilla.ro>
Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants