Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Attempts to fix installation ping not being sent #9254

Merged
merged 1 commit into from Mar 19, 2020
Merged

No issue: Attempts to fix installation ping not being sent #9254

merged 1 commit into from Mar 19, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Mar 19, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested review from boek and liuche March 19, 2020 16:29
@liuche
Copy link
Contributor

liuche commented Mar 19, 2020

I filed #9256 for this because Marissa wanted to be able to see an issue!

@sblatz sblatz force-pushed the fix-installation-ping-not-sent branch from 9aac777 to 7667b46 Compare March 19, 2020 22:39
@sblatz sblatz force-pushed the fix-installation-ping-not-sent branch from 7667b46 to a1427c6 Compare March 19, 2020 22:52
liuche
liuche approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like just moving context and instantiation.

@sblatz sblatz merged commit b9059c8 into mozilla-mobile:master Mar 19, 2020
@liuche liuche mentioned this pull request Mar 24, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuche liuche liuche approved these changes

@boek boek Awaiting requested review from boek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sblatz @liuche