Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #9291: Fix shortcutSearchEngineSettingsTest #9292

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Mar 20, 2020

No description provided.

@AaronMT AaronMT added the eng:automation Build automation, Continuous integration, .. label Mar 20, 2020
@AaronMT AaronMT requested a review from isabelrios March 20, 2020 20:20
@AaronMT AaronMT self-assigned this Mar 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #9292 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9292   +/-   ##
=========================================
  Coverage     19.53%   19.53%           
  Complexity      511      511           
=========================================
  Files           329      329           
  Lines         13173    13173           
  Branches       1749     1749           
=========================================
+ Hits           2573     2574    +1     
  Misses        10374    10374           
+ Partials        226      225    -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/components/Search.kt 100.00% <0.00%> (+8.33%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8a9bb...194134c. Read the comment docs.

Copy link
Contributor

@isabelrios isabelrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Run the tests several times in different devices, no failures!

@AaronMT AaronMT merged commit f804846 into mozilla-mobile:master Mar 23, 2020
@AaronMT AaronMT deleted the search-engine-ui-fix branch March 23, 2020 15:04
@liuche liuche mentioned this pull request Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants