Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #9433: Update Flank version in ui-tests Dockerfile #9466

Merged

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Mar 27, 2020

v8.0.1 -> flank_snapshot (see #9433)

https://github.com/Flank/flank/releases

@AaronMT AaronMT self-assigned this Mar 27, 2020
@codecov-io
Copy link

codecov-io commented Mar 27, 2020

Codecov Report

Merging #9466 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9466      +/-   ##
============================================
+ Coverage     19.42%   19.51%   +0.09%     
- Complexity      520      523       +3     
============================================
  Files           334      331       -3     
  Lines         13419    13316     -103     
  Branches       1786     1770      -16     
============================================
- Hits           2607     2599       -8     
+ Misses        10589    10494      -95     
  Partials        223      223
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/components/Components.kt 29.23% <0%> (-2.44%) 1% <0%> (ø)
...la/fenix/collections/CollectionCreationFragment.kt 89.58% <0%> (-0.62%) 6% <0%> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 75.61% <0%> (-0.25%) 30% <0%> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...x/home/sessioncontrol/viewholders/TabViewHolder.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/mozilla/fenix/settings/logins/SavedLoginsView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...sessioncontrol/viewholders/CollectionViewHolder.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/java/org/mozilla/fenix/components/FxaServer.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...sions/SitePermissionsManagePhoneFeatureFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d55578...6f57bf3. Read the comment docs.

@AaronMT
Copy link
Contributor Author

AaronMT commented Mar 27, 2020

122 tests / 122 shards

[task 2020-03-27T18:39:53.418Z] {
[task 2020-03-27T18:39:53.418Z]   "code" : 400,
[task 2020-03-27T18:39:53.419Z]   "errors" : [ {
[task 2020-03-27T18:39:53.419Z]     "domain" : "global",
[task 2020-03-27T18:39:53.419Z]     "message" : "num_shards must be >= 1 and <= 50.",
[task 2020-03-27T18:39:53.419Z]     "reason" : "badRequest"
[task 2020-03-27T18:39:53.419Z]   } ],
[task 2020-03-27T18:39:53.419Z]   "message" : "num_shards must be >= 1 and <= 50.",
[task 2020-03-27T18:39:53.420Z]   "status" : "INVALID_ARGUMENT"
[task 2020-03-27T18:39:53.420Z] }

Interesting change. I'll try 50 and report on the timing.

@AaronMT AaronMT force-pushed the 9433-update-flank-version-uitest branch 2 times, most recently from 6ee512d to 1eb21a0 Compare March 27, 2020 23:26
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -28,7 +28,7 @@ jobs:
commands:
- [wget, {artifact-reference: '<signing/public/build/x86/geckoNightly/target.apk>'}, '-O', app.apk]
- [wget, {artifact-reference: '<signing-android-test/public/build/noarch/geckoNightly/target.apk>'}, '-O', android-test.apk]
- [automation/taskcluster/androidTest/ui-test.sh, x86, app.apk, android-test.apk, '-1']
- [automation/taskcluster/androidTest/ui-test.sh, x86, app.apk, android-test.apk, '50']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: does 50 here overrides what's defined in automation/taskcluster/androidTest/flank-x86.yml? (not blocking this PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should always use the shard value provided by the templates, which is not happening right now #9185

@AaronMT AaronMT force-pushed the 9433-update-flank-version-uitest branch from 1eb21a0 to 5aa78b0 Compare March 30, 2020 15:27
@AaronMT
Copy link
Contributor Author

AaronMT commented Mar 30, 2020

7m 4s on flank_snapshot

I'm also looking into the GoogleJsonResponseException and legacy-result reporting in the Firebase Community

Edit: This appears to be extra misleading noise and is a bug on snapshot. The legacy reporting also has a bug on snapshot. I am told that success Firebase URL logging will be very soon (tomorrow) in flank-snapshot.

@AaronMT AaronMT force-pushed the 9433-update-flank-version-uitest branch 4 times, most recently from d49bd65 to 6f57bf3 Compare March 30, 2020 20:27
@AaronMT
Copy link
Contributor Author

AaronMT commented Mar 30, 2020

@JohanLorenzo Just want to confirm wether new flank-snapshot changes (that could update reguarily) will force new docker rebuilding and if so, is that ok?

@JohanLorenzo
Copy link
Contributor

JohanLorenzo commented Mar 31, 2020

@AaronMT I'm sorry, it won't. Some changes have to happen in taskcluster/docker/ui-tests/Dockerfile in order to force a new docker image build. It could be dummy change like adding a space somewhere. The original intent is to build new images only when it's needed and the only way for taskgraph to know is to monitor changes in checked-in files.

That said, we could write a cron job that monitors https://api.github.com/repos/Flank/flank/releases and then opens a PR to update taskcluster/docker/ui-tests/Dockerfile. @pocmo and I solved a similar case 2 weeks ago in #9251 🙂

fix: flank_snapshot requires direct shard value

-1 shards -> 50 shards

fix: adjust flank-x86.yml shard value

try old results generator in flank-x86.yml

fix: legacy-junit-report -> legacy-junit-result

revert to modern reporting
@AaronMT AaronMT force-pushed the 9433-update-flank-version-uitest branch from 6f57bf3 to 89bd07c Compare March 31, 2020 14:48
@AaronMT AaronMT added the eng:automation Build automation, Continuous integration, .. label Mar 31, 2020
@rpappalax rpappalax merged commit 8b34f37 into mozilla-mobile:master Apr 1, 2020
@liuche liuche mentioned this pull request Apr 13, 2020
32 tasks
@AaronMT AaronMT deleted the 9433-update-flank-version-uitest branch April 22, 2020 19:24
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants