-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #9433: Update Flank version in ui-tests Dockerfile #9466
Closes #9433: Update Flank version in ui-tests Dockerfile #9466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9466 +/- ##
============================================
+ Coverage 19.42% 19.51% +0.09%
- Complexity 520 523 +3
============================================
Files 334 331 -3
Lines 13419 13316 -103
Branches 1786 1770 -16
============================================
- Hits 2607 2599 -8
+ Misses 10589 10494 -95
Partials 223 223
Continue to review full report at Codecov.
|
122 tests / 122 shards
Interesting change. I'll try 50 and report on the timing. |
6ee512d
to
1eb21a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -28,7 +28,7 @@ jobs: | |||
commands: | |||
- [wget, {artifact-reference: '<signing/public/build/x86/geckoNightly/target.apk>'}, '-O', app.apk] | |||
- [wget, {artifact-reference: '<signing-android-test/public/build/noarch/geckoNightly/target.apk>'}, '-O', android-test.apk] | |||
- [automation/taskcluster/androidTest/ui-test.sh, x86, app.apk, android-test.apk, '-1'] | |||
- [automation/taskcluster/androidTest/ui-test.sh, x86, app.apk, android-test.apk, '50'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: does 50 here overrides what's defined in automation/taskcluster/androidTest/flank-x86.yml
? (not blocking this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we should always use the shard value provided by the templates, which is not happening right now #9185
1eb21a0
to
5aa78b0
Compare
I'm also looking into the Edit: This appears to be extra misleading noise and is a bug on snapshot. The legacy reporting also has a bug on snapshot. I am told that success Firebase URL logging will be very soon (tomorrow) in flank-snapshot. |
d49bd65
to
6f57bf3
Compare
@JohanLorenzo Just want to confirm wether new flank-snapshot changes (that could update reguarily) will force new docker rebuilding and if so, is that ok? |
@AaronMT I'm sorry, it won't. Some changes have to happen in That said, we could write a cron job that monitors https://api.github.com/repos/Flank/flank/releases and then opens a PR to update |
fix: flank_snapshot requires direct shard value -1 shards -> 50 shards fix: adjust flank-x86.yml shard value try old results generator in flank-x86.yml fix: legacy-junit-report -> legacy-junit-result revert to modern reporting
6f57bf3
to
89bd07c
Compare
v8.0.1 -> flank_snapshot (see #9433)
https://github.com/Flank/flank/releases