Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Snackbar position #9628

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Snackbar position #9628

merged 1 commit into from
Apr 2, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Apr 2, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #9628 into master will decrease coverage by 0.10%.
The diff coverage is 4.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9628      +/-   ##
============================================
- Coverage     19.35%   19.25%   -0.11%     
  Complexity      519      519              
============================================
  Files           335      335              
  Lines         13486    13568      +82     
  Branches       1794     1794              
============================================
+ Hits           2610     2612       +2     
- Misses        10651    10731      +80     
  Partials        225      225              
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/addons/Extensions.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...org/mozilla/fenix/browser/FenixSnackbarDelegate.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lla/fenix/customtabs/ExternalAppBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../onboarding/OnboardingAutomaticSignInViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ozilla/fenix/library/bookmarks/BookmarkFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nix/library/bookmarks/edit/EditBookmarkFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208a58b...bbb4875. Read the comment docs.

@sblatz sblatz force-pushed the snackbar-position branch 2 times, most recently from 92cfdbf to f2333bb Compare April 2, 2020 18:07
… Refactors snackbar creation and fixes placement
@sblatz sblatz marked this pull request as ready for review April 2, 2020 18:13
@sblatz sblatz requested a review from ekager April 2, 2020 18:16
@sblatz sblatz merged commit e3ed7ed into mozilla-mobile:master Apr 2, 2020
@liuche liuche mentioned this pull request Apr 13, 2020
32 tasks
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants