Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #9687: Refactor onboarding cards to follow app architecture #9743

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Apr 6, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@boek boek merged commit dfded8e into mozilla-mobile:master Apr 6, 2020
@liuche liuche mentioned this pull request Apr 13, 2020
32 tasks
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
@mcarare mcarare deleted the onboarding-refactor branch June 3, 2020 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants