Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Revert #9606 - do not retry build on fail #9855

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Revert #9606 - do not retry build on fail #9855

merged 1 commit into from
Apr 10, 2020

Conversation

rpappalax
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rpappalax rpappalax added eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels Apr 10, 2020
JohanLorenzo
JohanLorenzo approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we made this experiment! Too bad we don't have a better way to know what type of failures we got

@rpappalax rpappalax merged commit 6b6b3da into master Apr 10, 2020
@rpappalax rpappalax deleted the do-not-retry branch April 10, 2020 16:34
@liuche liuche mentioned this pull request Apr 13, 2020
Closed
32 tasks
liuche pushed a commit that referenced this pull request Apr 13, 2020
@rpappalax @liuche
Revert #9606 - do not retry build on fail (#9855)
115c5eb
@liuche liuche mentioned this pull request Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohanLorenzo JohanLorenzo JohanLorenzo approved these changes

Assignees
No one assigned
Labels
eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rpappalax @JohanLorenzo