Close #9960: Launch URI in Fenix if failed to launch in custom tab

[rocketsroger]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[codecov-io]

Codecov Report

Merging #9964 into master will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9964      +/-   ##
============================================
- Coverage     19.37%   19.17%   -0.21%     
+ Complexity      538      521      -17     
============================================
  Files           339      336       -3     
  Lines         13801    13732      -69     
  Branches       1847     1844       -3     
============================================
- Hits           2674     2633      -41     
+ Misses        10888    10860      -28     
  Partials        239      239              

Impacted Files	Coverage Δ	Complexity Δ
app/src/main/java/org/mozilla/fenix/Config.kt	26.82% <0.00%> (-3.73%)	2.00 <0.00> (ø)
...lla/fenix/customtabs/ExternalAppBrowserFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...ain/java/org/mozilla/fenix/perf/StartupTimeline.kt	0.00% <0.00%> (-62.50%)	0.00% <0.00%> (-2.00%)
...nix/components/toolbar/BrowserToolbarController.kt	64.70% <0.00%> (-1.58%)	0.00% <0.00%> (ø%)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt	11.18% <0.00%> (-1.23%)	3.00% <0.00%> (-1.00%)
.../java/org/mozilla/fenix/browser/BrowserAnimator.kt	7.40% <0.00%> (-0.44%)	0.00% <0.00%> (ø%)
...src/main/java/org/mozilla/fenix/components/Push.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...java/org/mozilla/fenix/push/FirebasePushService.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...a/org/mozilla/fenix/addons/AddonDetailsFragment.kt	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909ee73...b448e22. Read the comment docs.

[jonalmeida]

At the time, when we added the deepLinkScheme, the only use case for it was in the manifest.

I don't think we can avoid the duplication to set the values in the manifest an in the Kotlin layer, but what do you think about using a buildConfigField so we set the values in the same build.gradle place? We wouldn't need the Config.deepLinkScheme parsing and it would be less likely for errors if we decide to change our variants tomorrow (it's quite likely actually with LeanPlum things 😄 ).

[rocketsroger]

Sure, I'll look into creating a buildConfigField. Thanks,

[jonalmeida]

✨

[jonalmeida]

Oh nice! I didn't think this would work for some reason.

[rocketsroger]

Me too. Luckily found this: https://developer.android.com/studio/build/gradle-tips#share-properties-with-the-manifest

[jonalmeida]

👏