Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797605 - Add API support for ignoring sites for cookie banner handling #139

Merged
merged 1 commit into from Nov 23, 2022
Merged

Bug 1797605 - Add API support for ignoring sites for cookie banner handling #139

merged 1 commit into from Nov 23, 2022

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Nov 11, 2022 •
edited

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@Amejia481 Amejia481 added 🕵️‍♀️ needs review PRs that need to be reviewed work in progress Not ready to land yet. Work in progress (WIP). labels Nov 11, 2022
@Amejia481
Copy link
Contributor Author

@iorgamgabriel you can see an example of how this APIs are used in desktop to implement the toggle option in the toolbar.

@iorgamgabriel
Copy link
Contributor

Looks good to me! 👍

@Amejia481 Amejia481 force-pushed the bug-1797605 branch 2 times, most recently from c216781 to fc9b5ed Compare November 23, 2022 01:24
@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed work in progress Not ready to land yet. Work in progress (WIP). labels Nov 23, 2022
@Amejia481 Amejia481 removed the 🛬 needs landing PRs that are ready to land label Nov 23, 2022
@Amejia481 Amejia481 merged commit a2dfa59 into mozilla-mobile:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iorgamgabriel iorgamgabriel iorgamgabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amejia481 @iorgamgabriel