Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1807232 - Revert GeckoView to previous version to fix startup crash #434

Closed
wants to merge 1 commit into from

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Dec 23, 2022

@amocirean helped confirm that this backout fixes the startup crash seen on Fenix - mozilla-mobile/fenix#28297.
Also confirmed that with the current (newer) version of GV sample-browser crashes also but latest Nightly of Focus and latest GeckoView-example apps are not crashing so for a deeper fix we need to investigate what Fenix does that trigger the crash.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2022

This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏

@gabrielluong
Copy link
Member

I am gonna close this since we already discussed that we can't revert GV versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants