Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1870232 - Delegate the Activity's getNavDirections() functionality #4854

Merged
merged 1 commit into from Jan 18, 2024

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Dec 15, 2023

Step 2 from Bug 1865306 - RFC Custom Tabs

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1870232

@t-p-white t-p-white added the do not land PRs that requires coordination before landing label Dec 15, 2023
@t-p-white t-p-white requested a review from a team December 15, 2023 10:41
@github-actions github-actions bot added the 🕵️‍♀️ needs review PRs that need to be reviewed label Dec 15, 2023
@t-p-white t-p-white force-pushed the 1870232 branch 2 times, most recently from c298991 to 9a2de5b Compare December 15, 2023 11:45
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're in a new release cycle, I'm cool with approving this 👍

This comment was marked as resolved.

@github-actions github-actions bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 4, 2024
@t-p-white t-p-white changed the title Bug 1870232 - Create a navigation file that takes a HomeActivity to delegate the Activity's getNavDirections() functionality Bug 1870232 - Delegate the Activity's getNavDirections() functionality Jan 4, 2024
@t-p-white
Copy link
Contributor Author

t-p-white commented Jan 4, 2024

Now that we're in a new release cycle, I'm cool with approving this 👍

Thanks @MozillaNoah! While resolving the conflict I've also moved the code from the separate 'navigation' file to be in the Activity extension file based on feedback on another review

@t-p-white t-p-white removed the do not land PRs that requires coordination before landing label Jan 4, 2024
@t-p-white
Copy link
Contributor Author

Latest push updates the nav_graph to set the default arg to null so we no longer need to provide this explicitly 🙂

cc @MozillaNoah

@t-p-white t-p-white force-pushed the 1870232 branch 2 times, most recently from 829d3c3 to 4646ca0 Compare January 8, 2024 17:25

This comment was marked as resolved.

This comment was marked as resolved.

@t-p-white t-p-white force-pushed the 1870232 branch 3 times, most recently from cf5637d to 5e641e4 Compare January 17, 2024 10:59
@t-p-white t-p-white added 🛬 needs landing PRs that are ready to land and removed 🛬 needs landing PRs that are ready to land labels Jan 17, 2024
@t-p-white t-p-white force-pushed the 1870232 branch 3 times, most recently from c1fdbdb to f5ced6f Compare January 18, 2024 09:36

This comment was marked as resolved.

@t-p-white t-p-white force-pushed the 1870232 branch 2 times, most recently from 0379795 to ba26deb Compare January 18, 2024 10:49
@t-p-white t-p-white added the 🛬 needs landing PRs that are ready to land label Jan 18, 2024
@mergify mergify bot merged commit 7fa5dc8 into mozilla-mobile:main Jan 18, 2024
23 checks passed
@t-p-white t-p-white deleted the 1870232 branch January 18, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants