New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1870232 - Delegate the Activity's getNavDirections() functionality #4854
Conversation
c298991
to
9a2de5b
Compare
fenix/app/src/main/java/org/mozilla/fenix/HomeActivityNavDirections.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're in a new release cycle, I'm cool with approving this 👍
This comment was marked as resolved.
This comment was marked as resolved.
Thanks @MozillaNoah! While resolving the conflict I've also moved the code from the separate 'navigation' file to be in the Activity extension file based on feedback on another review |
Latest push updates the cc @MozillaNoah |
829d3c3
to
4646ca0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
cf5637d
to
5e641e4
Compare
c1fdbdb
to
f5ced6f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0379795
to
ba26deb
Compare
Step 2 from Bug 1865306 - RFC Custom Tabs
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-apk-{fenix,focus,klar}-debug
task you're interested in.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1870232