Skip to content

Commit

Permalink
Bug 1408076 - remove Set HomePage action from page options menu (#3293)
Browse files Browse the repository at this point in the history
  • Loading branch information
farhanpatel committed Oct 13, 2017
1 parent 3de7860 commit e2d2aee
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion Client/Frontend/Strings.swift
Expand Up @@ -398,7 +398,6 @@ extension Strings {
public static let AppMenuSettingsTitleString = NSLocalizedString("Menu.OpenSettingsAction.Title", tableName: "Menu", value: "Settings", comment: "Label for the button, displayed in the menu, used to open the Settings menu.")
public static let AppMenuCloseAllTabsTitleString = NSLocalizedString("Menu.CloseAllTabsAction.Title", tableName: "Menu", value: "Close All Tabs", comment: "Label for the button, displayed in the menu, used to close all tabs currently open.")
public static let AppMenuOpenHomePageTitleString = NSLocalizedString("Menu.OpenHomePageAction.Title", tableName: "Menu", value: "Open Homepage", comment: "Label for the button, displayed in the menu, used to navigate to the home page.")
public static let AppMenuSetHomePageTitleString = NSLocalizedString("Menu.SetHomePageAction.Title", tableName: "Menu", value: "Set as Homepage", comment: "Label for the button, displayed in the menu, used to set the homepage if none is currently set.")
public static let AppMenuTopSitesTitleString = NSLocalizedString("Menu.OpenTopSitesAction.AccessibilityLabel", tableName: "Menu", value: "Top Sites", comment: "Accessibility label for the button, displayed in the menu, used to open the Top Sites home panel.")
public static let AppMenuBookmarksTitleString = NSLocalizedString("Menu.OpenBookmarksAction.AccessibilityLabel", tableName: "Menu", value: "Bookmarks", comment: "Accessibility label for the button, displayed in the menu, used to open the Bbookmarks home panel.")
public static let AppMenuHistoryTitleString = NSLocalizedString("Menu.OpenHistoryAction.AccessibilityLabel", tableName: "Menu", value: "History", comment: "Accessibility label for the button, displayed in the menu, used to open the History home panel.")
Expand Down
6 changes: 1 addition & 5 deletions Client/Frontend/Widgets/PhotonActionSheetProtocol.swift
Expand Up @@ -120,10 +120,6 @@ extension PhotonActionSheetProtocol {
tab.toggleDesktopSite()
}

let setHomePage = PhotonActionSheetItem(title: Strings.AppMenuSetHomePageTitleString, iconString: "menu-Home") { action in
HomePageHelper(prefs: self.profile.prefs).setHomePage(toTab: tab, presentAlertOn: presentableVC)
}

let addReadingList = PhotonActionSheetItem(title: Strings.AppMenuAddToReadingListTitleString, iconString: "addToReadingList") { action in
guard let tab = self.tabManager.selectedTab else { return }
guard let url = tab.url?.displayURL else { return }
Expand Down Expand Up @@ -199,7 +195,7 @@ extension PhotonActionSheetProtocol {
topActions.append(addReadingList)
}

return [topActions, [copyURL, findInPageAction, toggleDesktopSite, pinToTopSites, setHomePage], [share]]
return [topActions, [copyURL, findInPageAction, toggleDesktopSite, pinToTopSites], [share]]
}
}

0 comments on commit e2d2aee

Please sign in to comment.