Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimbus FML breaks a-s local swift package manager flow #12243

Closed
skhamis opened this issue Oct 26, 2022 · 1 comment · Fixed by #12247
Closed

Nimbus FML breaks a-s local swift package manager flow #12243

skhamis opened this issue Oct 26, 2022 · 1 comment · Fixed by #12247
Assignees
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@skhamis
Copy link
Contributor

skhamis commented Oct 26, 2022

Steps to reproduce

  1. Follow the steps in locally publishing a SPM from application-services
  2. Build via XCode to run the app

Expected behavior

App builds successfully

Actual behavior

Error in the nimbus-fml.sh script

Error: No https://github.com/mozilla/rust-components-swift package was detected.
The package must be added as a project dependency.
Command PhaseScriptExecution failed with a nonzero exit code

Script in question: https://github.com/mozilla-mobile/firefox-ios/blob/main/bin/nimbus-fml.sh#L79-L86

Device & build information

  • Device: ?
  • Build version: ?

Notes

Attachments:

┆Issue is synchronized with this Jira Task

@skhamis skhamis added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Oct 26, 2022
@travis79
Copy link
Member

travis79 commented Oct 27, 2022

This is breaking because when using the local testing workflow for A-S/rust-components-swift because the local testing workflow updates the Xcode project file to use a local path (file:///) to the rust-components-swift checkout. Since the script you linked only ever looks for https://github.com/mozilla/rust-components-swift, it would always hit the failure case and report that it wasn't added as a dependency, even though it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
3 participants