Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review hard-coded used of GCDWebServer port as a possible startup crasher #1278

Closed
garvankeeley opened this issue Nov 18, 2015 · 2 comments
Closed

Review hard-coded used of GCDWebServer port as a possible startup crasher #1278

garvankeeley opened this issue Nov 18, 2015 · 2 comments

Comments

@garvankeeley
Copy link
Contributor

I have had this fail once in the simulator trying to use the fixed port. I don't recall the workflow that triggered it. Has no one else seen this during development? I assume this isn't showing up in release builds.
https://github.com/mozilla/firefox-ios/blob/master/Client/Application/WebServer.swift#L22
Consider trying a range of ports before failing.
IMHO seems like an unnecessary risk to rely on the network stack and process system to be bug-free on all iOS variants and properly release that port if the app crashes and is quickly restarted.
@st3fan
Copy link
Contributor

st3fan commented Apr 30, 2016

If brave uses the same port number, please change it.

@st3fan st3fan closed this as completed Apr 30, 2016
@garvankeeley
Copy link
Contributor Author

Will do. Currently it searches for an unused port.

isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 19, 2024
@oliviabrown9
Fixes mozilla-mobile#1278: FindInPageTest Fails on 7.0 (mozilla-mobil…
8181e81 
…e#1287)

* Not ideal but working

* Working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@st3fan @garvankeeley