"Web session" is displayed in Firefox iOS Account Management page

[SimonBasca]

Steps to reproduce

1. Log in to FxA
2. Go to Account Management Page -> Devices & Apps

Expected behavior

• The device ID should be displayed as it is on Firefox 24.1.

Actual behavior

• "Web session" text is displayed

Device & build information

• Device: iPhone Xr (13.3)
• Build version: 25.0 (17678)

Notes

Attachments:

• Firefox 24.1 screenshot
  

-Firefox 25.0(17678)

┆Issue is synchronized with this Jira Task

[garvankeeley]

@vladikoff any idea how we can filter this?

[ryanfeeley]

I think this is related to the technical implementation, but whatever backflips are required to make this look like Firefox for iOS (icon, text, etc), should certainly happen.

[vladikoff]

@vladikoff any idea how we can filter this?

Hm we need to make sure that the message here opens with the correct token:

firefox-ios/RustFxA/FxAWebView.swift

Line 193 in e7fec57

sessionToken: "\(token)",

This is what should make the
appear as the current device

[athomasmoz]

@vladikoff Is this something to be fixed on the FxA side or something else you need from us?

[vladikoff]

I'll take a look at this, at this time I am not sure where the culprit is.

…

On Thu, Apr 23, 2020 at 12:00 PM athomasmoz ***@***.***> wrote: @vladikoff <https://github.com/vladikoff> Is this something to be fixed on the FxA side or something else you need from us? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7N45TTOZQCRI4CNUT27TROBQZFANCNFSM4MITETVQ> .

[vladikoff]

Still looking at this...

[vladikoff]

To fix the issue with the "Current Device" we need to switch to using the uid instead of the email as follows:

diff --git a/RustFxA/FxAWebView.swift b/RustFxA/FxAWebView.swift
index 200d6f397..ed43769c2 100755
--- a/RustFxA/FxAWebView.swift
+++ b/RustFxA/FxAWebView.swift
@@ -189,12 +189,14 @@ extension FxAWebView: WKScriptMessageHandler {
         let data: String
         if pageType == .settingsPage {
             let fxa = RustFirefoxAccounts.shared.accountManager
-            let email = fxa.accountProfile()?.email ?? ""
+            let uid = fxa.accountProfile()?.uid ?? ""
             let token = (try? fxa.getSessionToken().get()) ?? ""
             data = """
-            {   signedInUser: {
+            {
+                capabilities: {},
+                signedInUser: {
                     sessionToken: "\(token)",
-                    email: "\(email)",
+                    uid: "\(uid)",
                     verified: true,
                 }
             }

Even with this change we will see Web Sessions in the list, I'll follow up on a way to deal with that in a bit...

[vladikoff]

👍