Change up the nimbus-fml.sh script and split up the nimbus.fml.yaml file. #11263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adudenamedruby
added
the
Do Not Merge ⛔️
adudenamedruby
approved these changes
Jul 13, 2022
jhugman
force-pushed
the
jhugman/exp-2605-get-ready-for-nimbus-fml
branch
from
febab66
to
45858ee
Compare
|
This pull request has conflicts when rebasing. Could you fix it @jhugman? |
1 similar comment
|
This pull request has conflicts when rebasing. Could you fix it @jhugman? |
jhugman
force-pushed
the
jhugman/exp-2605-get-ready-for-nimbus-fml
branch
from
45858ee
to
19d9abe
Compare
adudenamedruby
removed
the
Do Not Merge ⛔️
|
Will test & review today. |
|
BR is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is now ready to merge, but for when firefox-ios takes the (currently unreleased) upgrade which contains the EXP-2333 epic implementing the FML Imports and Includes proposal.
This PR does not go very far in splitting up the
nimbus.fml.yamlfile; I could go further, but would like to get some feedback before proceeding.The last PR this was waiting for was mozilla/application-services#5042 , which was released as part of App Services release v93.7.0 .
This PR splits out the app-specific configuration of the
nimbus-fmlcall, into two config files:nimbus-fml-configuration.sh, and optionally:nimbus-fml-configuration.local.sh. This file overrides anything in the first, and is intended for local development.It also derives the version of App Services, ensuring that the version of the megazord and FML stay in sync.
Thank you for submitting a pull request, your contributions are greatly appreciated!
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please make sure you've run the test scheme and all the tests pass. If your changes affect existing tests please make sure to update the tests as well.
Below is the PR naming guidelines we follow:
https://github.com/mozilla-mobile/firefox-ios/wiki/Pull-Request-Naming-Guide