Localize FXIOS-4802 [v106] Fix warnings on string exports #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
commented
Aug 25, 2022
flodolo
commented
Aug 25, 2022
|
This pull request has conflicts when rebasing. Could you fix it @flodolo? |
lmarceau
changed the title
flodolo
force-pushed
the
more_id_conflits
branch
from
794a6d4
to
e395398
Compare
lmarceau
reviewed
Aug 25, 2022
flodolo
force-pushed
the
more_id_conflits
branch
from
4ad392c
to
fdae753
Compare
lmarceau
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the warnings in the log, minus the 3 related to Info.plist (see #11667, FXIOS-4802)
I can fix those 3 as well, but uplifting localization would become a challenge: after exposing the strings in v106, uplifting to the v105 branch should remove the translations for the keys still needed in 105.
It can be done, but it requires manually adding back the 3 strings to the next export, and it's better to done it in a separate PR, since this one adds a bunch of new strings to translate.