Localize FXIOS-4802 [v106] Fix warnings for Info.plist keys #11720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
changed the title
|
Note: for this one, it would be good to double check that everything works as expected, as I'm not sure where/how to verify it. I think having the ID as string, then use it to localize is a brittle hack. Without the en* .strings files, there would be no trace of what the value (text) of those strings should be. |
|
Bitrise build is green here |
lmarceau
changed the title
lmarceau
reviewed
Aug 29, 2022
There was a problem hiding this comment.
LGTM but for sure other InfoPlist.strings file keys and translations will need to be adjusted too.
Quick summary for anyone wondering, this solves warnings:
--- WARNING: Key "ShortcutItemTitleQRCode" used with multiple values. Value "Scan QR Code" kept. Value "ShortcutItemTitleQRCode" ignored.
--- WARNING: Key "ShortcutItemTitleNewTab" used with multiple values. Value "New Tab" kept. Value "ShortcutItemTitleNewTab" ignored.
--- WARNING: Key "ShortcutItemTitleNewPrivateTab" used with multiple values. Value "New Private Tab" kept. Value "ShortcutItemTitleNewPrivateTab" ignored.
lmarceau
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11667 FXIOS-4802
@Delphine
Heads-up: this will require manual work to avoid losing existing translations for the old keys.
Once 105 is completely frozen, we can use automation as normal.