Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localized FXIOS-4915 [v106] Fix duplicate string IDs in wallpaper section #11878

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Localized FXIOS-4915 [v106] Fix duplicate string IDs in wallpaper section #11878

merged 1 commit into from
Sep 12, 2022

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Sep 12, 2022

String IDs Wallpaper.Download.Error.Title.v106 and Wallpaper.Change.Error.Title.v106 are assigned to two different Swift strings.

thatswinnie
thatswinnie approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@thatswinnie thatswinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this @flodolo 🙏🏼

@lmarceau
Copy link
Contributor

Build is green here
Screen Shot 2022-09-12 at 10 25 08 AM

@lmarceau lmarceau changed the title Localized FXIOS-11877 [v106] Fix duplicate string IDs in wallpaper section Localized FXIOS-4915 [v106] Fix duplicate string IDs in wallpaper section Sep 12, 2022
@lmarceau lmarceau merged commit 2977e6e into mozilla-mobile:main Sep 12, 2022
@flodolo flodolo deleted the issue11877 branch September 13, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flodolo @lmarceau @thatswinnie