Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-5255 [v109] Add Site image fetcher #12487

Merged
merged 5 commits into from
Nov 24, 2022
Merged

Add FXIOS-5255 [v109] Add Site image fetcher #12487

merged 5 commits into from
Nov 24, 2022

Conversation

lmarceau
Copy link
Contributor

FXIOS-5255 #12386

  • New site image fetcher for the Browser kit project. This is a wrapper on Kingfisher ImageDownloader.
  • Kingfisher is no longer embedded in the project within a separate target so we can add this dependency to BrowserKit.
  • Won't run BR for this PR as this is in a different package. Ran the tests locally for it.

@lmarceau lmarceau requested a review from OrlaM November 24, 2022 17:38
@lmarceau lmarceau merged commit 45cda04 into mozilla-mobile:main Nov 24, 2022
@lmarceau lmarceau deleted the lm/FXIOS-5255-site-image-fetcher branch November 24, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrlaM OrlaM OrlaM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmarceau @OrlaM