Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FXIOS-5343 [v109] Removes migrate bookmarks to places db #12580

Conversation

tarikeshaq
Copy link
Collaborator

A part of #12527, but doesn't close that ticket

The migration is really old, and was removed once before but kept for tests

We should remove it for good. This is a PR to try to see if tests still fail, otherwise let's make sure it only runs in a test environment

@lmarceau
Copy link
Contributor

lmarceau commented Dec 5, 2022

It wasn't used in tests, so it looks like this is good to merge.

@lmarceau
Copy link
Contributor

lmarceau commented Dec 5, 2022

Note: This code was attempted to be removed in the past (in 2020) but then put back due to some UI tests failures. Let's remove it for good.

@lmarceau lmarceau changed the title Removes FXIOS-5343 [v109] Removes migrate bookmarks to places db Remove FXIOS-5343 [v109] Removes migrate bookmarks to places db Dec 5, 2022
@lmarceau lmarceau merged commit 3bb8453 into mozilla-mobile:main Dec 5, 2022
@tarikeshaq tarikeshaq deleted the removes-very-old-bookmarks-migration branch December 5, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants