Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-6414 [v115] Improvement for session restore helper #14466

Conversation

lmarceau
Copy link
Contributor

Jira ticket

Description

Improvement for session restore helper, unwrapping params to avoid a crash.

Pull requests checks where applicable

  • Fill in the three TODOs above (tickets number and description of your work)
  • The PR name follows our naming guidelines
  • Accessibility implemented and tested (minimum Dynamic Text and VoiceOver)
  • Unit tests written and passing
  • Documentation / comments for complex code and public methods

@lmarceau lmarceau requested a review from OrlaM May 18, 2023 17:08
@lmarceau lmarceau requested a review from a team as a code owner May 18, 2023 17:08
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.8%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.01

File Coverage
SessionRestoreHelper.swift 39.13% ⚠️

Generated by 🚫 Danger Swift against 982486d

@lmarceau lmarceau merged commit 3d40d05 into mozilla-mobile:main May 18, 2023
10 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-6414-session-restore-improvement branch May 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants