Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FXIOS-6036 [v117] clean up coordinator code #15637

Merged

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Removing the old code path without coordinators in v117. This is a bigger PR so if we ever want to look how things were done before, we have 1 PR only to look at to have the overview.

  • Remove the coordinator feature flag
  • Remove unneeded deeplink code (with NavigationRouter and QuickActions)
  • Remove setup of BVC in SceneDelegate
  • Removing code unneeded in BVC (369 lines 🎉 more to come with subsequent coordinator code).

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

@lmarceau lmarceau requested a review from a team as a code owner July 18, 2023 20:18
Copy link
Contributor

@adudenamedruby adudenamedruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

This pull request has conflicts when rebasing. Could you fix it @lmarceau? 🙏

@mobiletest-ci-bot
Copy link

Warnings
⚠️ Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review. Consider using epic branches for work that would affect main.
Messages
📖 Project coverage: 34.27%
📖 Edited 25 files
📖 Created 0 files

Client.app: Coverage: 32.6

File Coverage
CoordinatorFlagManager.swift 61.11%
ErrorPageHelper.swift 0.0% ⚠️
PasswordManagerListViewController.swift 29.93% ⚠️
RecentlyClosedTabsPanel.swift 0.0% ⚠️
HomepageViewController.swift 36.35% ⚠️
SurveySurfaceViewController.swift 3.08% ⚠️
QuickActions.swift 0.0% ⚠️
DefaultBrowserOnboardingViewController.swift 3.61% ⚠️
SceneDelegate.swift 18.52% ⚠️
BrowserViewController+TabToolbarDelegate.swift 11.68% ⚠️
SearchTelemetry.swift 5.63% ⚠️
NimbusFlaggableFeature.swift 98.5%
BrowserViewController+WebViewDelegates.swift 2.08% ⚠️
ScreenshotHelper.swift 5.32% ⚠️
BrowserViewController+KeyCommands.swift 0.0% ⚠️
YourRightsSetting.swift 0.0% ⚠️
BrowserViewController+DownloadQueueDelegate.swift 0.0% ⚠️
SurveySurfaceManager.swift 97.96%
NimbusFeatureFlagLayer.swift 76.98%
BrowserViewController+URLBarDelegate.swift 2.37% ⚠️
BrowserViewController.swift 13.55% ⚠️

Generated by 🚫 Danger Swift against d4a0517

@lmarceau lmarceau merged commit 7730af9 into mozilla-mobile:main Jul 19, 2023
8 of 10 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-6036-clean-up-coordnator-code branch July 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants