Refactor FXIOS-8936 Sample Component Library to incorporate UUID-based themes #19740
Conversation
| import Foundation | ||
| import Common | ||
|
|
||
| let defaultSampleComponentUUID = UUID(uuidString: "44BA0B7D-097A-484D-8358-91A6E374451D")! |
There was a problem hiding this comment.
copied over from client side, but happy to use UUID() if that's preferred
There was a problem hiding this comment.
I don't think in this case the specific UUID value should matter so this should be fine. 👍 That UUID was intended originally for the UI tests but we can use it here, I'm not aware of any conflict it would cause.
|
@mattreaganmozilla here's a quick fix to resolve the build errors for the Sample Component Library, but let me know if there's a different path that should be taken! |
Generated by 🚫 Danger Swift against e00e6bc |
| window = UIWindow(windowScene: windowScene) | ||
| window?.rootViewController = navigationController | ||
| window?.makeKeyAndVisible() | ||
|
|
||
| guard let window else { return } |
There was a problem hiding this comment.
Super-minor suggestion: if we store the UIWindow() result first in a local non-optional it avoids the need for the guard (and the optional ? before calling functions).
let newWindow = UIWindow(windowScene: windowScene)
window = newWindow
newWindow.rootViewController = navigationController
// … etcThere was a problem hiding this comment.
thanks for the suggestion, updated!
📜 Tickets
Jira ticket
Github issue
💡 Description
Address build errors in the Sample Component Library due to updates in our theming being based on window UUID. Since this is a sample project and no plans now to support multiwindows, created an extension to minimize this build warnings.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)