Refactor FXIOS-9165 - Updated Fonts On SettingsViewController to FXFontStyles

[tisumi99]

📜 Tickets

Jira ticket
Github issue

💡 Description

Updated the settings views to use FXFontsStyle instead of DefaultDynamicFontHelper or UIFont. This eliminates the need to specify font sizes in the view controllers.

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[tisumi99]

[tisumi99]

I updated the PR so that there are no changes to the UI now. Was previously matching the orginal font style and FXFontStyles had a different size in some cases. Now matching to font size instead.

[mobiletest-ci-bot]

	Warnings
⚠️	Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️	Variable 'cross' in Medium is out of alphabetical order.

	Messages
📖	Project coverage: 32.54%
📖	Edited 3 files
📖	Created 0 files

Client.app: Coverage: 31.2

File	Coverage
ContentBlockerSettingViewController.swift	7.42%	⚠️
SettingsTableViewController.swift	25.95%	⚠️
ThemeSettingsController.swift	36.51%	⚠️

Generated by 🚫 Danger Swift against a5ed831

[cyndichin]

I updated the PR so that there are no changes to the UI now. Was previously matching the orginal font style and FXFontStyles had a different size in some cases. Now matching to font size instead.

thanks for the details @tisumi99, will let you know if any issues in matching the font size.

[cyndichin]

thank you for picking up the standardize font tickets and providing screenshots @tisumi99! this helps greatly, appreciate it :)