Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-9164 - Updated Fonts On SurveySurfaceViewController to FXFontStyles #20326

Merged
merged 1 commit into from
May 23, 2024
Merged

Refactor FXIOS-9164 - Updated Fonts On SurveySurfaceViewController to FXFontStyles #20326

merged 1 commit into from
May 23, 2024

Conversation

tisumi99
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Updated SurveySurfaceViewController to use FXFontsStyle instead of DefaultDynamicFontHelper or UIFont. This eliminates the need to specify font sizes in the view controllers.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tisumi99 tisumi99 requested a review from a team as a code owner May 17, 2024 19:16
@tisumi99 tisumi99 requested a review from dataports May 17, 2024 19:16
@tisumi99
Copy link
Contributor Author

Screenshot 2024-05-17 at 3 25 57 PM

@cyndichin cyndichin requested review from cyndichin and cwzilla and removed request for dataports May 20, 2024 13:49
@mobiletest-ci-bot
Copy link

Warnings
⚠️ Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️ Variable 'cross' in Medium is out of alphabetical order.
Messages
📖 Project coverage: 32.54%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 31.2

File Coverage
SurveySurfaceViewController.swift 3.72% ⚠️

Generated by 🚫 Danger Swift against 50fc1f5

@cyndichin cyndichin merged commit 41c42bc into mozilla-mobile:main May 23, 2024
10 checks passed
@tisumi99 tisumi99 deleted the 20307SurveySurfaceViewControllerFXFontStyles branch May 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyndichin cyndichin cyndichin approved these changes

@cwzilla cwzilla cwzilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tisumi99 @mobiletest-ci-bot @cyndichin @cwzilla