Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-9242 - Updated Fonts On ThemedTable #20493

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Refactor FXIOS-9242 - Updated Fonts On ThemedTable #20493

merged 1 commit into from
Jun 13, 2024

Conversation

tisumi99
Copy link
Contributor

馃摐 Tickets

Jira ticket
Github issue

馃挕 Description

Updated ThemedTableViewCell and ThemedTableSectionHeaderFooterView to use FXFontsStyle instead of DefaultDynamicFontHelper or UIFont. This eliminates the need to specify font sizes in the view controllers.

馃摑 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tisumi99 tisumi99 requested a review from a team as a code owner May 30, 2024 18:30
@tisumi99 tisumi99 requested a review from PARAIPAN9 May 30, 2024 18:30
@tisumi99
Copy link
Contributor Author

Screenshot 2024-05-30 at 11 30 58鈥疉M

@cyndichin cyndichin requested a review from cwzilla June 11, 2024 13:17
cyndichin
cyndichin approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks @tisumi99!~

@mobiletest-ci-bot
Copy link

Messages
馃摉 Project coverage: 32.09%
馃摉 Edited 2 files
馃摉 Created 0 files

Client.app: Coverage: 30.71

File Coverage
ThemedTableSectionHeaderFooterView.swift 0.0% 鈿狅笍
ThemedTableViewCell.swift 36.11% 鈿狅笍

Generated by 馃毇 Danger Swift against 16bfc6a

@cyndichin cyndichin merged commit a14538b into mozilla-mobile:main Jun 13, 2024
9 of 10 checks passed
@data-sync-user data-sync-user mentioned this pull request Jun 13, 2024
Open
@tisumi99 tisumi99 deleted the 20468ThemingFXFontStyles branch June 13, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyndichin cyndichin cyndichin approved these changes

@cwzilla cwzilla cwzilla approved these changes

@PARAIPAN9 PARAIPAN9 Awaiting requested review from PARAIPAN9 PARAIPAN9 is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tisumi99 @mobiletest-ci-bot @cyndichin @cwzilla