Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9178 Add theming support #20604

Merged
merged 22 commits into from
Jun 11, 2024
Merged

Add FXIOS-9178 Add theming support #20604

merged 22 commits into from
Jun 11, 2024

Conversation

razvanlitianu
Copy link
Collaborator

@razvanlitianu razvanlitianu commented Jun 10, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

Adding theme change support.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@razvanlitianu razvanlitianu marked this pull request as ready for review June 10, 2024 09:36
@razvanlitianu razvanlitianu requested a review from a team as a code owner June 10, 2024 09:36
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.09%
📖 Edited 9 files
📖 Created 0 files

Client.app: Coverage: 30.71

File Coverage
AddressAutofillCoordinator.swift 61.05% ✅
AddressListViewModel.swift 76.81% ✅
AddressAutofillSettingsViewModel.swift 70.37% ✅
AddressListView.swift 0.0% ⚠️
AddressAutofillSettingsView.swift 0.0% ⚠️
SettingsCoordinator.swift 93.85% ✅
EditAddressViewController.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 5d1c8d5

@razvanlitianu razvanlitianu merged commit 40ef878 into mozilla-mobile:main Jun 11, 2024
10 checks passed
@razvanlitianu razvanlitianu deleted the rlitianu/FXIOS-9178-#20337-Add-Theming-Support branch June 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 nbhasin2 approved these changes

@issammani issammani Awaiting requested review from issammani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@razvanlitianu @mobiletest-ci-bot @nbhasin2