Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1359754 - Adding tests to cover some missing scenarios in AS Test… #2664

Merged
merged 1 commit into from May 3, 2017

Conversation

isabelrios
Copy link
Contributor

… Suite

@isabelrios isabelrios changed the title Bug 1259754 - Adding tests to cover some missing scenarios in AS Test… Bug 1359754 - Adding tests to cover some missing scenarios in AS Test… Apr 26, 2017
@codecov-io
Copy link

Codecov Report

Merging #2664 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2664      +/-   ##
=========================================
+ Coverage   54.27%   54.3%   +0.03%     
=========================================
  Files         476     476              
  Lines       97370   97370              
=========================================
+ Hits        52846   52876      +30     
+ Misses      44524   44494      -30
Impacted Files Coverage Δ
Client/Frontend/Browser/TabScrollController.swift 11.22% <0%> (-4.28%) ⬇️
ThirdParty/sqlcipher/sqlite3.c 62.67% <0%> (+0.08%) ⬆️
SyncTests/TestBookmarkModel.swift 85.89% <0%> (+0.64%) ⬆️
ThirdParty/UIImageColors.swift 88.2% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbbd03...c9caa4e. Read the comment docs.

@isabelrios isabelrios force-pushed the isabelrios/Bug1359754-AddingTestsToASTestSuite branch from c933965 to 2c481f4 Compare April 28, 2017 19:34
@isabelrios
Copy link
Contributor Author

@npark-mozilla Please, when you have sometime r? after adding the disabled TopSites UI tests to this Test Suite too.
Thanks!

@isabelrios isabelrios force-pushed the isabelrios/Bug1359754-AddingTestsToASTestSuite branch 2 times, most recently from 639d57b to 2c414d9 Compare May 3, 2017 15:00
@isabelrios
Copy link
Contributor Author

Failures due to known issues not related to the ones in this PR

@isabelrios isabelrios merged commit 210b930 into master May 3, 2017
@isabelrios isabelrios deleted the isabelrios/Bug1359754-AddingTestsToASTestSuite branch May 4, 2017 07:22
jhreis pushed a commit to jhreis/firefox-ios that referenced this pull request Oct 23, 2017
jjSDET pushed a commit to jjSDET/firefox-ios that referenced this pull request Feb 13, 2024
…ounded with a page loaded (mozilla-mobile#2664)

Co-authored-by: Bogdan Cernea <bogdan.cernea@softvision.com>
Co-authored-by: Stefan Arentz <stefan@arentz.ca>
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 19, 2024
…ounded with a page loaded (mozilla-mobile#2664)

Co-authored-by: Bogdan Cernea <bogdan.cernea@softvision.com>
Co-authored-by: Stefan Arentz <stefan@arentz.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants