Fix #5795 - Error page not shown on reload #5800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old reload logic was to use a timestamp to determine if the error
page was being loaded or reloaded. The idea was that if errorpage load
was called with a timestamped URL <2s, load the errorpage html file; if
errorpage load was called with a timestamped URL >2s old then reload the
original page. It allowed for one codepath to handle the load/reload logic,
but it is very flaky.
Instead just have the reload buttons have special behaviour to reload
the original URL.