Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5795 - Error page not shown on reload #5800

Merged

Conversation

garvankeeley
Copy link
Contributor

The old reload logic was to use a timestamp to determine if the error
page was being loaded or reloaded. The idea was that if errorpage load
was called with a timestamped URL <2s, load the errorpage html file; if
errorpage load was called with a timestamped URL >2s old then reload the
original page. It allowed for one codepath to handle the load/reload logic,
but it is very flaky.
Instead just have the reload buttons have special behaviour to reload
the original URL.

The old reload logic was to use a timestamp to determine if the error
page was being loaded or reloaded. The idea was that if errorpage load
was called with a timestamped URL <2s, load the errorpage normally; if
errorpage load was called with a timestamped URL >2s old then reload the
original page. It allowed for one codepath to handle the reload logic,
but it is very flaky.
Instead just have the reload buttons have special behaviour to reload
the original URL.
@mozillamobilebot
Copy link

SwiftLint found issues

Warnings

File Line Reason
Tab.swift 192 Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Tab.swift 368 Prefer empty collection over optional collection. (discouraged_optional_collection)
Tab.swift 372 Prefer empty collection over optional collection. (discouraged_optional_collection)
Tab.swift 566 Prefer empty collection over optional collection. (discouraged_optional_collection)
Tab.swift 257 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

Errors

File Line Reason
Tab.swift 401 There should be no space before and one after any comma. (comma)

Generated by 🚫 Danger

@garvankeeley garvankeeley merged commit a49c6f9 into mozilla-mobile:master Nov 25, 2019
@garvankeeley garvankeeley deleted the gk/bug5795-errorpage branch April 8, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants