Fix #5826 - XCUITests fail to type in URL bar #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelrios
force-pushed
the
isabelrios/Issue5826-XCUITestsFailToTypeInURLBar
branch
from
2e45de3
to
508d960
Compare
isabelrios
force-pushed
the
isabelrios/Issue5826-XCUITestsFailToTypeInURLBar
branch
from
9127f31
to
5b3957c
Compare
isabelrios
force-pushed
the
isabelrios/Issue5826-XCUITestsFailToTypeInURLBar
branch
from
8b306d4
to
2e6f6db
Compare
|
@garvankeeley I think I got a workaround for the issue #5826, there are several BB runs in which that error is not present (the only failures are due to the fxa login page not being shown and the search engine addition from button tests that need to be updated) |
garvankeeley
approved these changes
Dec 10, 2019
isabelrios
deleted the
isabelrios/Issue5826-XCUITestsFailToTypeInURLBar
branch
garvankeeley
pushed a commit
that referenced
this pull request
Dec 11, 2019
* Fix #5826 - XCUITests fail to type in URL bar * waitfor textfield url before typing * change url for address * try tapping on address textField first * new fixes * using firstMatch instead of address or url * trying to find workaround * more fixes * wait longer for webview to be loaded * comment workaround * fix waiting for fxaccount website * removing sleep
garvankeeley
added a commit
that referenced
this pull request
Dec 20, 2019
…handling (#5944) * Fix #5848: Remove add search engine button from keyboard (#5857) * Fix #5868 update onepassword in carthage (#5870) * change source of onepassword-app-extension and update * Update Cartfile * Update Cartfile.resolved * Fix: Expression implicitly coerced from '[String : Any?]' to '[String : Any]' (#5876) * Add Fragment Support for Search Terms (#5847) * add fragment support for search engine * refactor and re indent file * add test case of fragment usage for search term * Revert "Fix #5868 update onepassword in carthage (#5870)" (#5883) This reverts commit 13c3398. * Fix #5877 [iPad][iOS 12.x] Library panel buttons are cut off * Organize LibraryViewController into separate files * Fix #5868: update 1pw in cartfile (#5884) * Fix UIView.isHidden must be used from main thread only (#5875) * Fix UIView.isHidden must be used from main thread only * Revert "Fix UIView.isHidden must be used from main thread only" This reverts commit e5ce847. * FirefoxAccountStateChange post notification wrapped to notify on the main thread. * Fix #5877 - [iPad][iOS 12.x] Library panel buttons are cut off (#5886) * Fix #5826 - XCUITests fail to type in URL bar (#5831) * Fix #5826 - XCUITests fail to type in URL bar * waitfor textfield url before typing * change url for address * try tapping on address textField first * new fixes * using firstMatch instead of address or url * trying to find workaround * more fixes * wait longer for webview to be loaded * comment workaround * fix waiting for fxaccount website * removing sleep * Fix: Expression implicitly coerced from '[String : Any?]' to '[String : Any]' (#5876) * Add Fragment Support for Search Terms (#5847) * add fragment support for search engine * refactor and re indent file * add test case of fragment usage for search term * Revert "Fix #5868 update onepassword in carthage (#5870)" (#5883) This reverts commit 13c3398. * Fix #5868: update 1pw in cartfile (#5884) * Fix UIView.isHidden must be used from main thread only (#5875) * Fix UIView.isHidden must be used from main thread only * Revert "Fix UIView.isHidden must be used from main thread only" This reverts commit e5ce847. * FirefoxAccountStateChange post notification wrapped to notify on the main thread. * Fix #5826 - XCUITests fail to type in URL bar (#5831) * Fix #5826 - XCUITests fail to type in URL bar * waitfor textfield url before typing * change url for address * try tapping on address textField first * new fixes * using firstMatch instead of address or url * trying to find workaround * more fixes * wait longer for webview to be loaded * comment workaround * fix waiting for fxaccount website * removing sleep * Fix #5823 (#5861) Firefox loses URL when opening a link in a new tab without internet connection #5823 * Fix #5508 Add Unit tests for Everything and Today and Yesterday options for Clear Recent History, as well as test to validate that all expected options are shown for Clear Recent History (#5899) * Fix #5679 - Added ability for user remove an account if they are unable to verify email (#5897) - Added account removal alert - Moved UserDefaults Prefs helper to Shared so that we can easily write Profile / Account unit tests - Added a MockAccount class to mock the Firefox account for testing purposes * Fix #5904: UIView.isHidden must be used from main thread (#5906) * Fix #5866 if the webpage has low-res favicon, show default icon Changed to favicon to be displayed size minimum of 32x32 in TopSites * Fix #5862 - Reading list text is not fully displayed in landscapeMode (#5872) * Comment out Adjust launch * Comment out Leanplum launch * Comment out Sentry launch * Fix #5902 - XCUITests more iOS13 fixes (#5903) * Fix #5902 - XCUITests more iOS13 fixes * adding sleep * remove sleep and increase timeout * fix smoketest * Fix #5869 - The button from the toast notification is too small (#5895) * Fix #5869 - The button from the toast notification is too small * ButtonToast size change * Tapping 'Home' in menu directs to configurable homeURL * Register UserDefaults in AppDelegate, add settings to Settings.bundle * polyfillURL test * Fix #5888 - QR code frame is not aligned (#5922) * Fix #5915 - Doesn't build on latest Xcode (#5932) - Updated application-services to v0.47.0 * Issue #5753: Separated contributing from readme (#5929) * seperated contributing from readme * Removed upercase in "CONTRIBUTING" * Fix #5781 - [iPad] Tabs tray layout is not correct when entering split screen (#5925) * Default exposeWebXRAPI bool to true * setupNotifications() for XR session state * Check if multiple AR sessions are running Co-authored-by: Mustafa Hastürk <mustafa.hasturk@yandex.com> Co-authored-by: Daniela Arcese <darcese@mozilla.com> Co-authored-by: Garvan Keeley <garvankeeley+github@gmail.com> Co-authored-by: Nishant Bhasin <nikieme3@gmail.com> Co-authored-by: isabelrios <isabelrios@gmail.com> Co-authored-by: dfperry5 <DylanPerry5@gmail.com> Co-authored-by: Yuşa Doğru <yusadogru@gmail.com> Co-authored-by: KrystynaKruchkovska <37312950+KrystynaKruchkovska@users.noreply.github.com> Co-authored-by: Harsh Mehta <deadspaceharsh@gmail.com>
garvankeeley
added a commit
that referenced
this pull request
Jan 1, 2020
…pon reload/URL traversal, hook up onStartLoad (#5970) * Fix #5848: Remove add search engine button from keyboard (#5857) * Fix #5868 update onepassword in carthage (#5870) * change source of onepassword-app-extension and update * Update Cartfile * Update Cartfile.resolved * Fix: Expression implicitly coerced from '[String : Any?]' to '[String : Any]' (#5876) * Add Fragment Support for Search Terms (#5847) * add fragment support for search engine * refactor and re indent file * add test case of fragment usage for search term * Revert "Fix #5868 update onepassword in carthage (#5870)" (#5883) This reverts commit 13c3398. * Fix #5877 [iPad][iOS 12.x] Library panel buttons are cut off * Organize LibraryViewController into separate files * Fix #5868: update 1pw in cartfile (#5884) * Fix UIView.isHidden must be used from main thread only (#5875) * Fix UIView.isHidden must be used from main thread only * Revert "Fix UIView.isHidden must be used from main thread only" This reverts commit e5ce847. * FirefoxAccountStateChange post notification wrapped to notify on the main thread. * Fix #5877 - [iPad][iOS 12.x] Library panel buttons are cut off (#5886) * Fix #5826 - XCUITests fail to type in URL bar (#5831) * Fix #5826 - XCUITests fail to type in URL bar * waitfor textfield url before typing * change url for address * try tapping on address textField first * new fixes * using firstMatch instead of address or url * trying to find workaround * more fixes * wait longer for webview to be loaded * comment workaround * fix waiting for fxaccount website * removing sleep * Fix: Expression implicitly coerced from '[String : Any?]' to '[String : Any]' (#5876) * Add Fragment Support for Search Terms (#5847) * add fragment support for search engine * refactor and re indent file * add test case of fragment usage for search term * Revert "Fix #5868 update onepassword in carthage (#5870)" (#5883) This reverts commit 13c3398. * Fix #5868: update 1pw in cartfile (#5884) * Fix UIView.isHidden must be used from main thread only (#5875) * Fix UIView.isHidden must be used from main thread only * Revert "Fix UIView.isHidden must be used from main thread only" This reverts commit e5ce847. * FirefoxAccountStateChange post notification wrapped to notify on the main thread. * Fix #5826 - XCUITests fail to type in URL bar (#5831) * Fix #5826 - XCUITests fail to type in URL bar * waitfor textfield url before typing * change url for address * try tapping on address textField first * new fixes * using firstMatch instead of address or url * trying to find workaround * more fixes * wait longer for webview to be loaded * comment workaround * fix waiting for fxaccount website * removing sleep * Fix #5823 (#5861) Firefox loses URL when opening a link in a new tab without internet connection #5823 * Fix #5508 Add Unit tests for Everything and Today and Yesterday options for Clear Recent History, as well as test to validate that all expected options are shown for Clear Recent History (#5899) * Fix #5679 - Added ability for user remove an account if they are unable to verify email (#5897) - Added account removal alert - Moved UserDefaults Prefs helper to Shared so that we can easily write Profile / Account unit tests - Added a MockAccount class to mock the Firefox account for testing purposes * Fix #5904: UIView.isHidden must be used from main thread (#5906) * Fix #5866 if the webpage has low-res favicon, show default icon Changed to favicon to be displayed size minimum of 32x32 in TopSites * Fix #5862 - Reading list text is not fully displayed in landscapeMode (#5872) * Fix #5902 - XCUITests more iOS13 fixes (#5903) * Fix #5902 - XCUITests more iOS13 fixes * adding sleep * remove sleep and increase timeout * fix smoketest * Fix #5869 - The button from the toast notification is too small (#5895) * Fix #5869 - The button from the toast notification is too small * ButtonToast size change * Fix #5888 - QR code frame is not aligned (#5922) * Fix #5915 - Doesn't build on latest Xcode (#5932) - Updated application-services to v0.47.0 * Issue #5753: Separated contributing from readme (#5929) * seperated contributing from readme * Removed upercase in "CONTRIBUTING" * Fix #5781 - [iPad] Tabs tray layout is not correct when entering split screen (#5925) * Bug 1604804: blob download (#5935) * Fix #5559 - use special fingerprinting list / refactor python code to swift (#5936) * Port content blocker python code to swift * remove python file * Change build scripts * add license header * Fix #5928: Land strings for v22 cover sheet (#5943) * NoIssue-TryingToFixXcode11.3TestsFailures (#5939) * NoIssue-TryingToFixXcode11.3TestsFailures * disable sync and translation tests * new fixes for navigation, private browsing and tp * fix for dataManagement, domain autocomplete, homepagesettings * fix dataManagement, navigation and sync ui tests * Remove camera view when moving to non-XR site * Wired up "Stop AR" menu button with new web method * “Fix (#5948) using workaround to fix typeText issues forgot tap and check fix delete custom search engine Cleanup * Move applicationName as FxiOS to property (#5955) * Fix #5237 - 'Recent Bookmarks' header should match other table view headers (#5960) * Remove obsolete usingMetal, useMetalForARKey * Pause ARSession upon reload/URL traversal * Run onStartLoad when didStartProvisionalNavigation * Removed xrStopAR tabAction Co-authored-by: Mustafa Hastürk <mustafa.hasturk@yandex.com> Co-authored-by: Daniela Arcese <darcese@mozilla.com> Co-authored-by: Garvan Keeley <garvankeeley+github@gmail.com> Co-authored-by: Nishant Bhasin <nikieme3@gmail.com> Co-authored-by: isabelrios <isabelrios@gmail.com> Co-authored-by: dfperry5 <DylanPerry5@gmail.com> Co-authored-by: Yuşa Doğru <yusadogru@gmail.com> Co-authored-by: KrystynaKruchkovska <37312950+KrystynaKruchkovska@users.noreply.github.com> Co-authored-by: Harsh Mehta <deadspaceharsh@gmail.com> Co-authored-by: SimonBasca <32130829+SimonBasca@users.noreply.github.com> Co-authored-by: Mykola Aleshchenko <nick130586@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #5826