Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6012 - Enhanced Tracking Protection Coversheet #6228

Merged
merged 4 commits into from Mar 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 52 additions & 0 deletions Client.xcodeproj/project.pbxproj
Expand Up @@ -254,13 +254,20 @@
3D9CA9A81EF84D04002434DD /* NoImageTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3D9CA9A71EF84D04002434DD /* NoImageTests.swift */; };
3D9CAA1C1EFCD655002434DD /* ClipBoardTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3D9CAA1B1EFCD655002434DD /* ClipBoardTests.swift */; };
3DEFED081F55EBE300F8620C /* TrackingProtectionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3DEFED071F55EBE300F8620C /* TrackingProtectionTests.swift */; };
43446CE7240D9F3000F5C643 /* ETP.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 43446CE5240D9F3000F5C643 /* ETP.xcassets */; };
43446CEA2412066500F5C643 /* UIViewControllerExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43446CE92412066500F5C643 /* UIViewControllerExtension.swift */; };
43446CF02412DDBE00F5C643 /* UpdateCoverSheetViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43446CEF2412DDBE00F5C643 /* UpdateCoverSheetViewModelTests.swift */; };
43446CF32412F9FF00F5C643 /* ETPCoverSheetTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43446CF22412F9FF00F5C643 /* ETPCoverSheetTests.swift */; };
435D660323D793DF0046EFA2 /* UpdateModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 435D660223D793DF0046EFA2 /* UpdateModel.swift */; };
435D660523D794B90046EFA2 /* UpdateViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 435D660423D794B90046EFA2 /* UpdateViewModel.swift */; };
435D660723D7962C0046EFA2 /* UpdateCoverSheetTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 435D660623D7962C0046EFA2 /* UpdateCoverSheetTableViewCell.swift */; };
43A5643823CD1E1C00B6857D /* UpdateViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43A5643523CD1E1B00B6857D /* UpdateViewController.swift */; };
43A5643923CD1E1C00B6857D /* Update.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 43A5643623CD1E1B00B6857D /* Update.xcassets */; };
43B137EE23A173D900CB7FA0 /* MockAccount.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43B137ED23A173D900CB7FA0 /* MockAccount.swift */; };
43B137F223A181A200CB7FA0 /* NSUserDefaultsPrefs.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43B137F123A181A200CB7FA0 /* NSUserDefaultsPrefs.swift */; };
43DDB96A240994370058A068 /* ETPCoverSheetViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43DDB969240994360058A068 /* ETPCoverSheetViewController.swift */; };
43DDB96C240995A70058A068 /* ETPModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43DDB96B240995A70058A068 /* ETPModel.swift */; };
43DDB97624099F200058A068 /* ETPViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43DDB97524099F200058A068 /* ETPViewModel.swift */; };
4A59B58AD11B5EE1F80BBDEB /* TestHistory.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4A59BF410BBD9B3BE71F4C7C /* TestHistory.swift */; };
4F514FD41ACD8F2C0022D7EA /* HistoryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4F514FD31ACD8F2C0022D7EA /* HistoryTests.swift */; };
4F97573B1AFA6F37006ECC24 /* readerContent.html in Resources */ = {isa = PBXBuildFile; fileRef = 4F9757391AFA6F37006ECC24 /* readerContent.html */; };
Expand Down Expand Up @@ -1393,13 +1400,20 @@
3D9CA9A71EF84D04002434DD /* NoImageTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = NoImageTests.swift; sourceTree = "<group>"; };
3D9CAA1B1EFCD655002434DD /* ClipBoardTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ClipBoardTests.swift; sourceTree = "<group>"; };
3DEFED071F55EBE300F8620C /* TrackingProtectionTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TrackingProtectionTests.swift; sourceTree = "<group>"; };
43446CE5240D9F3000F5C643 /* ETP.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = ETP.xcassets; sourceTree = "<group>"; };
43446CE92412066500F5C643 /* UIViewControllerExtension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = UIViewControllerExtension.swift; path = Extensions/UIViewControllerExtension.swift; sourceTree = "<group>"; };
43446CEF2412DDBE00F5C643 /* UpdateCoverSheetViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UpdateCoverSheetViewModelTests.swift; sourceTree = "<group>"; };
43446CF22412F9FF00F5C643 /* ETPCoverSheetTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ETPCoverSheetTests.swift; sourceTree = "<group>"; };
435D660223D793DF0046EFA2 /* UpdateModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UpdateModel.swift; sourceTree = "<group>"; };
435D660423D794B90046EFA2 /* UpdateViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UpdateViewModel.swift; sourceTree = "<group>"; };
435D660623D7962C0046EFA2 /* UpdateCoverSheetTableViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UpdateCoverSheetTableViewCell.swift; sourceTree = "<group>"; };
43A5643523CD1E1B00B6857D /* UpdateViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UpdateViewController.swift; sourceTree = "<group>"; };
43A5643623CD1E1B00B6857D /* Update.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Update.xcassets; sourceTree = "<group>"; };
43B137ED23A173D900CB7FA0 /* MockAccount.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockAccount.swift; sourceTree = "<group>"; };
43B137F123A181A200CB7FA0 /* NSUserDefaultsPrefs.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = NSUserDefaultsPrefs.swift; sourceTree = "<group>"; };
43DDB969240994360058A068 /* ETPCoverSheetViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ETPCoverSheetViewController.swift; sourceTree = "<group>"; };
43DDB96B240995A70058A068 /* ETPModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ETPModel.swift; sourceTree = "<group>"; };
43DDB97524099F200058A068 /* ETPViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ETPViewModel.swift; sourceTree = "<group>"; };
4A59BF410BBD9B3BE71F4C7C /* TestHistory.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestHistory.swift; sourceTree = "<group>"; };
4F514FD31ACD8F2C0022D7EA /* HistoryTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = HistoryTests.swift; sourceTree = "<group>"; };
4F9757391AFA6F37006ECC24 /* readerContent.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = readerContent.html; sourceTree = "<group>"; };
Expand Down Expand Up @@ -2275,6 +2289,7 @@
E650754F1E37F6D1006961AC /* NSURLExtensionsMailTo.swift */,
E65075501E37F6D1006961AC /* UIViewExtensions.swift */,
C817B34C1FC609500086018E /* UIScrollViewSwizzled.swift */,
43446CE92412066500F5C643 /* UIViewControllerExtension.swift */,
);
name = Extensions;
sourceTree = "<group>";
Expand Down Expand Up @@ -2592,6 +2607,22 @@
path = XCUITests;
sourceTree = "<group>";
};
43446CED2412DDB100F5C643 /* UpdateCoverSheet */ = {
isa = PBXGroup;
children = (
43446CEF2412DDBE00F5C643 /* UpdateCoverSheetViewModelTests.swift */,
);
path = UpdateCoverSheet;
sourceTree = "<group>";
};
43446CF12412F9A800F5C643 /* ETPCoverSheet */ = {
isa = PBXGroup;
children = (
43446CF22412F9FF00F5C643 /* ETPCoverSheetTests.swift */,
);
path = ETPCoverSheet;
sourceTree = "<group>";
};
43A5643423CD1E1B00B6857D /* Update */ = {
isa = PBXGroup;
children = (
Expand All @@ -2604,6 +2635,17 @@
path = Update;
sourceTree = "<group>";
};
43DDB967240870AC0058A068 /* EnhancedTrackingProtection */ = {
isa = PBXGroup;
children = (
43446CE5240D9F3000F5C643 /* ETP.xcassets */,
43DDB969240994360058A068 /* ETPCoverSheetViewController.swift */,
43DDB96B240995A70058A068 /* ETPModel.swift */,
43DDB97524099F200058A068 /* ETPViewModel.swift */,
);
path = EnhancedTrackingProtection;
sourceTree = "<group>";
};
7B0B1B9C1C1B69F500DF4AB5 /* Extensions */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -3419,6 +3461,8 @@
F84B21D61A090F8100AAB793 /* ClientTests */ = {
isa = PBXGroup;
children = (
43446CF12412F9A800F5C643 /* ETPCoverSheet */,
43446CED2412DDB100F5C643 /* UpdateCoverSheet */,
8DCD3BCC1ED5B7FA00446D38 /* FxADeepLinkingTests.swift */,
3B6F40171DC7849C00656CC6 /* FirefoxHomeTests.swift */,
F84B21D91A090F8100AAB793 /* ClientTests.swift */,
Expand Down Expand Up @@ -3523,6 +3567,7 @@
7B0B1B9C1C1B69F500DF4AB5 /* Extensions */,
F84B22211A09122500AAB793 /* Home */,
EBC486972195F46A00CDA48D /* InternalSchemeHandler */,
43DDB967240870AC0058A068 /* EnhancedTrackingProtection */,
43A5643423CD1E1B00B6857D /* Update */,
E49943F31AE6879C00BF9DE4 /* Intro */,
D05434F3225FDA3400FDE4EF /* Library */,
Expand Down Expand Up @@ -4435,6 +4480,7 @@
7B42406E1CA04CAC009B5C28 /* Menu.xcassets in Resources */,
E49943F71AE69EDD00BF9DE4 /* Intro.xcassets in Resources */,
3BC659591E5BA505006D560F /* top_sites.json in Resources */,
43446CE7240D9F3000F5C643 /* ETP.xcassets in Resources */,
E4B7B7631A793CF20022C5E0 /* CharisSILI.ttf in Resources */,
C8399D9522DE5E6200EFA5CA /* disconnect-block-social.json in Resources */,
E4CD9F541A71506400318571 /* Reader.html in Resources */,
Expand Down Expand Up @@ -5013,6 +5059,7 @@
745DAB3F1CDAB09E00D44181 /* HistoryBackButton.swift in Sources */,
EB9A179D20E69A7F00B12184 /* Theme.swift in Sources */,
396E38F31EE0C90D00CC180F /* FxALoginHelper.swift in Sources */,
43DDB96C240995A70058A068 /* ETPModel.swift in Sources */,
274A36C9239EB94000A21587 /* LibraryPanelButton.swift in Sources */,
435D660523D794B90046EFA2 /* UpdateViewModel.swift in Sources */,
D0152245229855A8009DE753 /* OneLineCell.swift in Sources */,
Expand All @@ -5035,6 +5082,7 @@
39F819C61FD70F5D009E31E4 /* TabEventHandlers.swift in Sources */,
E65607611C08B4E200534B02 /* SearchInputView.swift in Sources */,
FA6B2AC21D41F02D00429414 /* Punycode.swift in Sources */,
43446CEA2412066500F5C643 /* UIViewControllerExtension.swift in Sources */,
D301AAEE1A3A55B70078DD1D /* TabTrayController.swift in Sources */,
EB9A179B20E69A7F00B12184 /* ThemeManager.swift in Sources */,
EBFDB790211C83A5005CCA2F /* BrowserViewController+FindInPage.swift in Sources */,
Expand Down Expand Up @@ -5115,6 +5163,7 @@
E653422D1C5944F90039DD9E /* BrowserPrompts.swift in Sources */,
2FDE87FE1ABB3817005317B1 /* RemoteTabsPanel.swift in Sources */,
39DD030D1CD53E1900BC09B3 /* HomePageHelper.swift in Sources */,
43DDB97624099F200058A068 /* ETPViewModel.swift in Sources */,
C4F3B29A1CFCF93A00966259 /* ButtonToast.swift in Sources */,
EBA3B2D02268F40C00728BDB /* SyncMenuButton.swift in Sources */,
D31A0FC71A65D6D000DC8C7E /* SearchSuggestClient.swift in Sources */,
Expand Down Expand Up @@ -5209,6 +5258,7 @@
E692E3291C46E62D009D1240 /* AuthenticationSettingsViewController.swift in Sources */,
E663D5781BB341C4001EF30E /* ToggleButton.swift in Sources */,
EBA3B2D22268F57E00728BDB /* BadgeIcon.swift in Sources */,
43DDB96A240994370058A068 /* ETPCoverSheetViewController.swift in Sources */,
E6327A641BF6438E008D12E0 /* DebugSettingsBundleOptions.swift in Sources */,
D8FDEB57220CFE970069A582 /* UIImage+ImageEffects.m in Sources */,
EBB89506219398E500EB91A0 /* TabContentBlocker.swift in Sources */,
Expand Down Expand Up @@ -5236,6 +5286,7 @@
2F697F7E1A9FD22D009E03AE /* SearchEnginesTests.swift in Sources */,
2F44FA1B1A9D426A00FD20CC /* TestHashExtensions.swift in Sources */,
3B39EDBA1E16E18900EF029F /* CustomSearchEnginesTest.swift in Sources */,
43446CF32412F9FF00F5C643 /* ETPCoverSheetTests.swift in Sources */,
D3FA777B1A43B2990010CD32 /* SearchTests.swift in Sources */,
D3BA41681BD82F2200DA5457 /* XCTestCaseExtensions.swift in Sources */,
43B137EE23A173D900CB7FA0 /* MockAccount.swift in Sources */,
Expand All @@ -5262,6 +5313,7 @@
E1D8BC7A21FF7A0000B100BD /* TPStatsBlocklistsTests.swift in Sources */,
D82ED2641FEB3C420059570B /* DefaultSearchPrefsTests.swift in Sources */,
3B61CD591F2A750800D38DE1 /* PocketFeedTests.swift in Sources */,
43446CF02412DDBE00F5C643 /* UpdateCoverSheetViewModelTests.swift in Sources */,
3B6F40181DC7849C00656CC6 /* FirefoxHomeTests.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
3 changes: 3 additions & 0 deletions Client/Application/LeanplumIntegration.swift
Expand Up @@ -40,7 +40,10 @@ enum LPEvent: String {
case secondRun = "E_Second_Run"
case openedApp = "E_Opened_App"
case dismissUpdateCoverSheetAndStartBrowsing = "E_Dismissed_Update_Cover_Sheet_And_Start_Browsing"
case dismissETPCoverSheetAndGoToSettings = "E_Dismissed_Update_Cover_Sheet_And_Go_To_Settings"
case dismissedUpdateCoverSheet = "E_Dismissed_Update_Cover_Sheet"
case dismissedETPCoverSheet = "E_Dismissed_ETP_Sheet"
case dismissETPCoverSheetAndStartBrowsing = "E_Dismissed_ETP_Cover_Sheet_And_Start_Browsing"
case dismissedOnboarding = "E_Dismissed_Onboarding"
case dismissedOnboardingShowLogin = "E_Dismissed_Onboarding_Showed_Login"
case dismissedOnboardingShowSignUp = "E_Dismissed_Onboarding_Showed_SignUpFlow"
Expand Down
5 changes: 5 additions & 0 deletions Client/Application/TestAppDelegate.swift
Expand Up @@ -60,6 +60,11 @@ class TestAppDelegate: AppDelegate {
profile = BrowserProfile(localName: "testProfile", syncDelegate: application.syncDelegate)
}

// Don't show the ETP Coversheet New page.
if launchArguments.contains(LaunchArguments.SkipETPCoverSheet) {
profile.prefs.setString(ETPCoverSheetShowType.DoNotShow.rawValue, forKey: PrefsKeys.KeyETPCoverSheetShowType)
}

// Don't show the What's New page.
if launchArguments.contains(LaunchArguments.SkipWhatsNew) {
profile.prefs.setInt(1, forKey: PrefsKeys.KeyLastVersionNumber)
Expand Down
24 changes: 24 additions & 0 deletions Client/Extensions/UIViewControllerExtension.swift
@@ -0,0 +1,24 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import Shared

enum NavigationItemLocation {
case Left
case Right
}

enum NavigationItemText {
case Done
case Close

func localizedString() -> String {
switch self {
case .Done:
return Strings.SettingsSearchDoneButton
case .Close:
return Strings.CloseButtonTitle
}
}
}