Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

title on FirefoxAccountSignInViewController, show instructions label in dark mode #6657

Merged
merged 3 commits into from May 21, 2020
Merged

title on FirefoxAccountSignInViewController, show instructions label in dark mode #6657

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
041434b
Add title on FirefoxAccountSignInViewController
kaylagalway May 21, 2020
224866d
topTabsVisible shouldbe true
kaylagalway May 21, 2020
b16750a
Handle label colors in dark mode
kaylagalway May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions RustFxA/FirefoxAccountSignInViewController.swift
View file
Open in desktop
Expand Up @@ -102,8 +102,10 @@ class FirefoxAccountSignInViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()
view.backgroundColor = .white
title = Strings.FxASignin_Title
addSubviews()
addViewConstraints()
handleDarkMode()
}

// MARK: Subview Layout Functions
Expand Down Expand Up @@ -147,6 +149,13 @@ class FirefoxAccountSignInViewController: UIViewController {
}
}

func handleDarkMode() {
[qrSignInLabel, instructionsLabel].forEach {
// UI is not currently themeable, enforce black
$0.textColor = .black
}
}

// MARK: Button Tap Functions

/// Scan QR code button tapped
Expand Down