Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix searchbar hide issue #6703

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Fix searchbar hide issue #6703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0640e00
remove hideSearchBarWhenScrolling in viewDidAppear
May 28, 2020
acb8818
unfold searchBar on viewDidAppear
May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions Client/Frontend/Settings/WebsiteDataManagementViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,14 @@ class WebsiteDataManagementViewController: UIViewController, UITableViewDataSour
searchController.searchBar.barStyle = .black
}
navigationItem.searchController = searchController
navigationItem.hidesSearchBarWhenScrolling = false
self.searchController = searchController

definesPresentationContext = true
}

override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)

// Allows the search bar to be scrolled away even though we initially show it.
navigationItem.hidesSearchBarWhenScrolling = true
unfoldSearchbar()
}

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
Expand Down Expand Up @@ -247,4 +244,9 @@ class WebsiteDataManagementViewController: UIViewController, UITableViewDataSour
showMoreButtonEnabled = false
tableView.reloadData()
}

private func unfoldSearchbar() {
guard let searchBarHeight = navigationItem.searchController?.searchBar.intrinsicContentSize.height else { return }
tableView.setContentOffset(CGPoint(x: 0, y: -searchBarHeight + tableView.contentOffset.y), animated: true)
}
}