Webxr update to bring branch in line with main branch #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when using Night mode (mozilla-mobile#5959) * Fix mozilla-mobile#4700: Reader view should switch to a darker theme when using Night Mode * Fix mozilla-mobile#4700 - Keep sepia as reader mode theme when switching back from dark to light in case sepia was used in light mode before * Fix mozilla-mobile#4700 - Refactor the code from previous commits * Fix mozilla-mobile#4700 - Fix the issue with reader mode changing its color after changing font size of font type * Fix mozilla-mobile#4976: Make Reader Mode respect accessibility settings (mozilla-mobile#5983) * Fix mozilla-mobile#4976: Make Reader Mode respect accessibility settings * Fix mozilla-mobile#4976 - Remove unused variable * Fix mozilla-mobile#4976 - Fix selected state for font buttons * Update after merge from master * Fix mozilla-mobile#4700: Code review feedback * Fix mozilla-mobile#4700: Remove unused init method Co-authored-by: Mykola Aleshchenko <maleschenko@homeawaycorp.com>
…zilla-mobile#6228) * Fix mozilla-mobile#6012 - Enhanced Tracking Protection Coversheet - Updated test cases to not show ETP screen randomly - Added ETP CoverSheet tests
…ebpack step (mozilla-mobile#6246) * Fix mozilla-mobile#6245 - Update uglify to terser js plugin for the webpack step * Update autogenerated files
…ile#6247) * [nobug, build] update app services to v54 (xcode 11.3.1) * update README
…6179) * Release checklist: add check for security advisories * Update release_checklist_template.md
…mobile#6248) App services requires this lib to be v1.8.0
…ge in customSearchVC (mozilla-mobile#6236) user input stays on theme change address extra lines feedback
* Fix#5873 - Share sheet not in dark mode * mozilla-mobile#5873: Create theme for shareExtension
…ab’s webview (mozilla-mobile#6117)" (mozilla-mobile#6252) This reverts commit 4c3cf89.
…rait mode for ETP Coversheet (mozilla-mobile#6258)
* Fix mozilla-mobile#6133: Add tab telemetry * Add telemetry docs in tree * issue mozilla-mobile#6133: Rename tab count ping
…zilla-mobile#6296) Fix mozilla-mobile#6272 for whatsapp to load the proper desktop website by using custom user agent
This will be used as a template when adding a new feature request. Note that it will auto-add the `Feature 🎁` label.
This will be used as a template when adding a new bug. Note that it will auto-add the `Bug 🐞` label.
…la-mobile#6169) * Fix6152 - Home 'Custom URL' placeholder text is barely visible * Update DarkTheme.swift removed white spaces
* add fragment support for search engine * refactor and re indent file * add test case of fragment usage for search term * change source of onepassword-app-extension and update * Update Cartfile * Update Cartfile.resolved * Fix UIView.isHidden must be used from main thread only * Revert "Fix UIView.isHidden must be used from main thread only" This reverts commit e5ce847. * FirefoxAccountStateChange post notification wrapped to notify on the main thread. * fix RustLogins warnings * migrade deprecated .lproj * add recommended base localizations * make background black when camera is denied * do not allow to open torch when denied camera Co-authored-by: Garvan Keeley <garvankeeley+github@gmail.com>
…ayed out when Passcode is OFF (mozilla-mobile#6250)
Added flags for building XRViewerDev and XRViewer conditional code.
…6866) * For mozilla-mobile#6865 - UI Test fix Strict TP test * update previous test
… or leanplum is slow wasn't met (mozilla-mobile#6850) (mozilla-mobile#6852)
* Issue 6711: Update colours in ETP shield icon * Fixes
…hing on text size change (mozilla-mobile#6881)
…ozilla-mobile#6853) * Add Search button to tabbar in home screen * Reduce icon flickering and add tests
* removing logic from controller * removing webview within viewModel * inject LeanPlumClient via init * cleanup * cleanup * applying pr changes * applying second waves of changes
…into webxr-update
this section should have been removed.
fixed user agent to have WebXRViewer in it as needed by the polyfill
Added XR directory back to project.
garvankeeley
requested review from
garvankeeley
and removed request for
garvankeeley
|
lgtm, nothing jumps out as problematic, hard to say with the volume of changes though. |
|
LMK if you need me to merge it in |
|
We could merge, ship TestFlight, and see if people could test ....
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Garvan Keeley <notifications@github.com>
Sent: Friday, July 10, 2020 4:18:04 PM
To: mozilla-mobile/firefox-ios <firefox-ios@noreply.github.com>
Cc: Blair MacIntyre <bmacintyre@mozilla.com>; Author <author@noreply.github.com>
Subject: Re: [mozilla-mobile/firefox-ios] Webxr update to bring branch in line with main branch (#6943)
LMK if you need me to merge it in
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#6943 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAKJJ7I55SXARQHGRLGMWWTR25ZPZANCNFSM4OVDJMGQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged changes to master/main from december till now, into webxr branch.