Bug 1183257 - Allow storing logins from iframes #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // if (/^about:accounts($|\?)/i.test(topWin.document.documentURI)) { | ||
| // log("(form submission ignored -- about:accounts)"); | ||
| // return; | ||
| // } |
|
@thebnich can you wrap this up and land it, either now or for 1.1? |
|
Rebased and opened #871. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows storing logins from iframes. We still won't be able to autofill them though, which makes this a bit silly. If you submit invalid data on twitch, they do redirect to the login page, so we should theoretically them fill in there, which is nice. And showing the prompt is nicer than nothing.
Trying to do any routing through the main document to insert logins into the child would mean exposing your credentials to the parent document. I don't think we can safely do that. Maybe with some same-domain checks?