Build and target SDK 28 (9.0) #991

pocmo · 2018-07-16T12:35:43Z

Why/User Benefit/User Problem

It will be a requirement for using new OS features
The longer we stay behind the harder it gets to update
We want to update to 28 in the components soon. To avoid conflicts we want to update the apps too.

What / Requirements

Update build.gradle files
Build and run tests to see if there are issues that need to be fixed
Is there a 28 support library release or does switching to SDK 28 mean we need to switch to the androidx.* support libraries (many of them seem to still have alpha version numbers).

mcomella · 2018-07-16T19:12:49Z

If possible, I'd like to wait until 28 is officially released (afaik, it's still Beta). My reasons for this are:

Jump to definition on the source code will decompile the code rather than taking you to the source (b/c sources aren't released until the platform is officially released?)
Instant run stops working (similar reasons?)

@pocmo Do you know how to fix these issues while upgrading to 28?

pocmo · 2018-07-17T08:57:59Z

Yes. we can still wait. SDK 28 seems to be final already. However there's no final image for any phone yet. Also the support libraries for 28 seem to be still in alpha. We may want to wait until they are final. Focus wants to build a feature based on the new biometric APIs, so I expect them to switch as soon as the support libraries are ready.

pocmo · 2018-08-28T07:29:34Z

FYI: Focus made the switch to SDK 28. In the components repository we are waiting for a final release of the support libraries (currently: 28.0.0-rc02) and maybe Robolectric 4.0 (which comes with support for API 28).

mcomella · 2018-09-24T21:12:09Z

FYI: SDK 28 is released: mozilla-mobile/android-components#404 (comment)

We should add KTX while we're at it.

pocmo · 2018-09-26T10:42:37Z

FYI: Android Components 0.26 is expected to require SDK 28 (tentative release date: October 5th)

mcomella · 2018-10-09T16:05:04Z

Emily mentioned for Focus:

it required a lot of Settings changes to support libraries. We also had to accept the new licenses which ended up being a bit complicated

mcomella · 2018-10-11T14:31:38Z

Also, API 28 blocks HTTP traffic by default so we need to add an option in our Android Manifest.

…l (lint check)

…agment.activity method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

- Update API 28 null annotation in BrowserNavigationOverlay - Locally declare non-null adapter (HomeTileAdapter) - Update onRequestChildFocus() to API 28 parameter types

…l (lint check)

…agment.activity method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

- Update API 28 null annotation in BrowserNavigationOverlay - Locally declare non-null adapter (HomeTileAdapter) - Update onRequestChildFocus() to API 28 parameter types

…l (lint check)

…agment.activity method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

- Update API 28 null annotation in BrowserNavigationOverlay - Locally declare non-null adapter (HomeTileAdapter) - Update onRequestChildFocus() to API 28 parameter types

…y method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

pocmo mentioned this issue Jul 16, 2018

Update to Android SDK 28 mozilla-mobile/android-components#404

Closed

bbinto added the ⛔ blocked label Aug 14, 2018

bbinto added this to the Backlog milestone Aug 14, 2018

bbinto added the P3 Low impact and frequency label Aug 14, 2018

mcomella removed the ⛔ blocked label Sep 24, 2018

psymoon self-assigned this Oct 12, 2018

psymoon modified the milestones: Backlog (P2, P3), Sprint 6 (3.1) Oct 12, 2018

athomasmoz modified the milestones: Sprint 6 (3.1), Q4 Sprint 1 Oct 12, 2018

athomasmoz added the size M 3 pts = 2-3 days = 12 - 18 hours label Oct 12, 2018

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Issue mozilla-mobile#991: Upgrade sdk & supportLib

5e1c7eb

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Issue mozilla-mobile#991: Set http cleartext to true

744f6ce

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Issue mozilla-mobile#991: Update onRequestChildFocus

abb1c72

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Issue mozilla-mobile#991: Add type updates in UI

b8bec90

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Issue mozilla-mobile#991: Add type updates in frameworks

d64209c

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Issue mozilla-mobile#991: Use components thumbnail for screenshot

989c4bb

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Closes mozilla-mobile#991: accept new licenses

ca345a0

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Closes mozilla-mobile#991: Fix tests

e852799

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Closes mozilla-mobile#991: Update settings_cookie_dialog_content

4f722ad

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Closes mozilla-mobile#991: Update buildtools for CI scripts

67afd24

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Closes mozilla-mobile#991: Fix tests

c284ddf

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 16, 2018

Closes mozilla-mobile#991: Update settings_cookie_dialog_content

e048a9b

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add automatic accept all SDK licenses to CI

79760d3

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Upgrade Roboletric to 4.0-alpha-3 for SDK 28

543cbc8

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add unusedAttribute for importantForAutofil…

ebee59a

…l (lint check)

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add SupportActivity type cast for BrowserFr…

3f78032

…agment.activity method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add usesCleartextTraffic

89f1be2

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add unusedAttribute for importantForAutofil…

8865e6d

…l (lint check)

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add SupportActivity type cast for BrowserFr…

f075a63

…agment.activity method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add usesCleartextTraffic

97b0a75

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Update Travis to accept SDK 28

28498ea

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Upgrade Roboletric to 4.0-alpha-3 for SDK 28

f4b6036

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add unusedAttribute for importantForAutofil…

1c342b0

…l (lint check)

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add SupportActivity type cast for BrowserFr…

fc1521f

…agment.activity method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

psymoon added a commit to psymoon/firefox-tv that referenced this issue Oct 23, 2018

Issue mozilla-mobile#991: Add usesCleartextTraffic

2c9b6bf

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Upgrade sdk & supportLib

f2fd813

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Update null types for SDK 28 (1/3)

9be1b52

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Update null types for SDK 28 (2/3)

6eb77f9

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Use components thumbnail for browser screenshots

8249303

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Update settings_cookie_dialog_content2 to TVScreenshots test

d52d393

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Update Travis to accept SDK 28

0e726aa

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Upgrade Roboletric to 4.0-alpha-3 for SDK 28

c015a44

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Add unusedAttribute for importantForAutofill (lint check)

2da8222

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Add SupportActivity type cast for BrowserFragment.activit…

368d9a9

…y method - SDK28 requires SupportActvity().{method} to be only called from within the same library group

liuche pushed a commit that referenced this issue Oct 23, 2018

Issue #991: Add usesCleartextTraffic

7775275

Required for SDK 28 (used for cleartext network traffic, such as cleartext HTTP)

liuche closed this as completed in 8e2cf83 Oct 23, 2018

ghost removed the needs review label Oct 23, 2018

mcomella mentioned this issue Oct 26, 2018

Move support libraries to androidx #1398

Closed

jonalmeida mentioned this issue Apr 21, 2020

Close #6601: Update targetSdkVersion to 29 mozilla-mobile/android-components#6730

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build and target SDK 28 (9.0) #991

Build and target SDK 28 (9.0) #991

pocmo commented Jul 16, 2018 •

edited by psymoon

Loading

mcomella commented Jul 16, 2018

pocmo commented Jul 17, 2018

pocmo commented Aug 28, 2018

mcomella commented Sep 24, 2018

pocmo commented Sep 26, 2018

mcomella commented Oct 9, 2018

mcomella commented Oct 11, 2018

Build and target SDK 28 (9.0) #991

Build and target SDK 28 (9.0) #991

Comments

pocmo commented Jul 16, 2018 • edited by psymoon Loading

Why/User Benefit/User Problem

What / Requirements

mcomella commented Jul 16, 2018

pocmo commented Jul 17, 2018

pocmo commented Aug 28, 2018

mcomella commented Sep 24, 2018

pocmo commented Sep 26, 2018

mcomella commented Oct 9, 2018

mcomella commented Oct 11, 2018

pocmo commented Jul 16, 2018 •

edited by psymoon

Loading