temp

[severinrudie]

While it fixes the bug, this is a terrible solution. Hopefully it helps point us in the right direction. The base problems here:

• If we remove the shared prefs check, onboarding is shown any time we are in an Auth state
• We go through Auth states all the time
  • Specifically, when a user starts the app already logged in, we travel through the normal flow
• AFAICT, what we really want is to show onboarding any time we go through Auth after the user has finished clicking through FxA login
  • We don't have a callback for that, so this solution sets the listener when they begin logging in
  • There are probably bad edge cases due to setting the listener on sign in start instead of sign in completion

[codecov-io]

Codecov Report

Merging #2866 into master will increase coverage by 0.03%.
The diff coverage is 47.61%.

@@             Coverage Diff              @@
##             master    #2866      +/-   ##
============================================
+ Coverage     52.13%   52.16%   +0.03%     
+ Complexity      477      475       -2     
============================================
  Files           122      119       -3     
  Lines          3493     3487       -6     
  Branches        448      447       -1     
============================================
- Hits           1821     1819       -2     
+ Misses         1522     1519       -3     
+ Partials        150      149       -1

Impacted Files	Coverage Δ	Complexity Δ
...main/java/org/mozilla/tv/firefox/utils/Settings.kt	50% <0%> (+1.51%)	5 <0> (ø)	⬇️
...rc/main/java/org/mozilla/tv/firefox/fxa/FxaRepo.kt	81.13% <100%> (+8.55%)	7 <1> (+1)	⬆️
...fox/navigationoverlay/NavigationOverlayFragment.kt	64.06% <30.76%> (-1.41%)	28 <1> (+1)
...ox/navigationoverlay/NavigationOverlayViewModel.kt	48.97% <50%> (+0.04%)	9 <1> (+1)	⬆️
.../mozilla/tv/firefox/webrender/WebRenderFragment.kt	41.23% <0%> (-0.34%)	10% <0%> (+1%)
...main/java/org/mozilla/tv/firefox/fxa/FxaProfile.kt
...g/mozilla/tv/firefox/framework/UnresolvedString.kt
.../java/org/mozilla/tv/firefox/fxa/FxaReceivedTab.kt
...c/main/java/org/mozilla/tv/firefox/MainActivity.kt	45.91% <0%> (+0.04%)	10% <0%> (-1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e6b65...0b5b2a8. Read the comment docs.